Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: webrtc/voice_engine/include/voe_base.h

Issue 2307533004: Moving/renaming webrtc/common.h. (Closed)
Patch Set: Comments+small fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/include/voe_base.h
diff --git a/webrtc/voice_engine/include/voe_base.h b/webrtc/voice_engine/include/voe_base.h
index 91df7d3e4f2c8dd688c2077da24acc0e48cf039c..1b8f06b54f64190080b64afff6d0f14be3e10e6e 100644
--- a/webrtc/voice_engine/include/voe_base.h
+++ b/webrtc/voice_engine/include/voe_base.h
@@ -36,6 +36,7 @@
#include "webrtc/base/scoped_ref_ptr.h"
#include "webrtc/modules/audio_coding/codecs/audio_decoder_factory.h"
+#include "webrtc/modules/audio_coding/include/audio_coding_module.h"
#include "webrtc/common_types.h"
namespace webrtc {
@@ -43,7 +44,6 @@ namespace webrtc {
class AudioDeviceModule;
class AudioProcessing;
class AudioTransport;
-class Config;
const int kVoEDefault = -1;
@@ -65,7 +65,6 @@ class WEBRTC_DLLEXPORT VoiceEngine {
// Creates a VoiceEngine object, which can then be used to acquire
// sub-APIs. Returns NULL on failure.
static VoiceEngine* Create();
- static VoiceEngine* Create(const Config& config);
// Deletes a created VoiceEngine object and releases the utilized resources.
// Note that if there are outstanding references held via other interfaces,
@@ -146,11 +145,10 @@ class WEBRTC_DLLEXPORT VoEBase {
virtual int Terminate() = 0;
// Creates a new channel and allocates the required resources for it.
- // One can use |config| to configure the channel. Currently that is used for
- // choosing between ACM1 and ACM2, when creating Audio Coding Module.
+ // One can use |acm_config| to configure the channel.
// Returns channel ID or -1 in case of an error.
virtual int CreateChannel() = 0;
- virtual int CreateChannel(const Config& config) = 0;
+ virtual int CreateChannel(const AudioCodingModule::Config& acm_config) = 0;
// Deletes an existing channel and releases the utilized resources.
// Returns -1 in case of an error, 0 otherwise.

Powered by Google App Engine
This is Rietveld 408576698