Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: webrtc/voice_engine/channel_manager.cc

Issue 2307533004: Moving/renaming webrtc/common.h. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/channel_manager.h ('k') | webrtc/voice_engine/include/voe_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/channel_manager.cc
diff --git a/webrtc/voice_engine/channel_manager.cc b/webrtc/voice_engine/channel_manager.cc
index bcc22b05f45a090a4605667ce01a6e007cdcff00..b8ffe6e796c239734e4748fd1e5d87305bdc527f 100644
--- a/webrtc/voice_engine/channel_manager.cc
+++ b/webrtc/voice_engine/channel_manager.cc
@@ -10,7 +10,6 @@
#include "webrtc/voice_engine/channel_manager.h"
-#include "webrtc/common.h"
#include "webrtc/voice_engine/channel.h"
namespace webrtc {
@@ -45,26 +44,13 @@ ChannelOwner& ChannelOwner::operator=(const ChannelOwner& other) {
ChannelOwner::ChannelRef::ChannelRef(class Channel* channel)
: channel(channel), ref_count(1) {}
-ChannelManager::ChannelManager(uint32_t instance_id, const Config& config)
- : instance_id_(instance_id), last_channel_id_(-1), config_(config) {}
+ChannelManager::ChannelManager(uint32_t instance_id)
+ : instance_id_(instance_id), last_channel_id_(-1) {}
ChannelOwner ChannelManager::CreateChannel(
- const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) {
- return CreateChannelInternal(config_, decoder_factory);
-}
-
-ChannelOwner ChannelManager::CreateChannel(
- const Config& external_config,
- const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) {
- return CreateChannelInternal(external_config, decoder_factory);
-}
-
-ChannelOwner ChannelManager::CreateChannelInternal(
- const Config& config,
- const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) {
+ const VoEBase::ChannelConfig& config) {
Channel* channel;
- Channel::CreateChannel(channel, ++last_channel_id_, instance_id_, config,
- decoder_factory);
+ Channel::CreateChannel(channel, ++last_channel_id_, instance_id_, config);
ChannelOwner channel_owner(channel);
rtc::CritScope crit(&lock_);
« no previous file with comments | « webrtc/voice_engine/channel_manager.h ('k') | webrtc/voice_engine/include/voe_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698