Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2306833003: Provide a default implementation for PeerConnectionInterface::ice_state(). (Closed)

Created:
4 years, 3 months ago by johan
Modified:
4 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Provide a default implementation for PeerConnectionInterface::ice_state(). Default implementation is necessary to remove implementations in downstream unit test mocks. Method will be entirely removed in upcomming reland of https://codereview.webrtc.org/2256663002/ . BUG=webrtc:6299 Committed: https://crrev.com/79c64585752de002b69f80575e580c48148d7221 Cr-Commit-Position: refs/heads/master@{#14053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
johan
4 years, 3 months ago (2016-09-02 13:37:40 UTC) #4
pthatcher1
lgtm
4 years, 3 months ago (2016-09-02 17:59:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306833003/1
4 years, 3 months ago (2016-09-02 17:59:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 19:07:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 19:07:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c64585752de002b69f80575e580c48148d7221
Cr-Commit-Position: refs/heads/master@{#14053}

Powered by Google App Engine
This is Rietveld 408576698