Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2306553002: Reland of Initial version of file wrapper (Closed)

Created:
4 years, 3 months ago by palmkvist
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Initial version of file wrapper Fixes a conversion issue. BUG=webrtc:6177 R=sprang@webrtc.org TBR=mflodman@webrtc.org patch from issue 2214763002 at patchset 450001 (http://crrev.com/2214763002#ps450001) Committed: https://crrev.com/4ec6a0ceae0a3d54a46fd4116cd503336ff32a20 Cr-Commit-Position: refs/heads/master@{#14044}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 2 chunks +12 lines, -0 lines 0 comments Download
A webrtc/base/file.h View 1 chunk +67 lines, -0 lines 0 comments Download
A webrtc/base/file.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A webrtc/base/file_posix.cc View 1 1 chunk +100 lines, -0 lines 0 comments Download
A webrtc/base/file_unittest.cc View 1 chunk +166 lines, -0 lines 0 comments Download
A webrtc/base/file_win.cc View 1 chunk +120 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
palmkvist
4 years, 3 months ago (2016-09-01 11:31:34 UTC) #2
sprang_webrtc
lgtm with nit fixed https://codereview.webrtc.org/2306553002/diff/1/webrtc/base/file_posix.cc File webrtc/base/file_posix.cc (right): https://codereview.webrtc.org/2306553002/diff/1/webrtc/base/file_posix.cc#newcode89 webrtc/base/file_posix.cc:89: return lseek(file_, static_cast<off_t>(offset), SEEK_SET) != ...
4 years, 3 months ago (2016-09-02 06:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306553002/20001
4 years, 3 months ago (2016-09-02 08:01:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-02 10:02:27 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4ec6a0ceae0a3d54a46fd4116cd503336ff32a20 Cr-Commit-Position: refs/heads/master@{#14044}
4 years, 3 months ago (2016-09-02 11:38:47 UTC) #12
palmkvist
4 years, 3 months ago (2016-09-02 11:38:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ec6a0ceae0a3d54a46fd4116cd503336ff32a20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698