Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2306513003: Stash non layer-sync frames if we have not yet received an earlier frame for this layer. (Closed)

Created:
4 years, 3 months ago by philipel
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Stash non layer-sync frames if we have not yet received an earlier frame for this layer. In VP8 the assumption is that a non layer-sync frame depends on all previous frames on temporal layers less or equal to this frames temporal layer. BUG=webrtc:5514 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d268d6ffbee619a19a68fa853b2abe97a9a85742

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/modules/video_coding/rtp_frame_reference_finder.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
philipel
4 years, 3 months ago (2016-09-01 09:44:29 UTC) #2
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-13 07:16:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306513003/1
4 years, 3 months ago (2016-09-13 10:21:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/14055)
4 years, 3 months ago (2016-09-13 10:24:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306513003/20001
4 years, 3 months ago (2016-09-13 11:17:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-13 13:18:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d268d6ffbee619a19a68fa853b2abe97a9a85742 Cr-Commit-Position: refs/heads/master@{#14229}
4 years, 3 months ago (2016-09-15 11:43:35 UTC) #14
philipel
4 years, 3 months ago (2016-09-15 11:43:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d268d6ffbee619a19a68fa853b2abe97a9a85742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698