Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2306433002: Add option to set maximum video encoder bitrate to AppRTCDemo. (Closed)

Created:
4 years, 3 months ago by AlexG
Modified:
4 years, 3 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add option to set maximum video encoder bitrate to AppRTCDemo. BUG=b/30951236 Committed: https://crrev.com/a70856c0bf7e2817a68b82bdb131cfdd608d18f3 Cr-Commit-Position: refs/heads/master@{#14028}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -51 lines) Patch
M webrtc/examples/androidapp/res/values/strings.xml View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/examples/androidapp/res/xml/preferences.xml View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 12 chunks +57 lines, -18 lines 1 comment Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
AlexG
PTAL
4 years, 3 months ago (2016-08-31 22:50:08 UTC) #2
wzh
lgtm https://codereview.webrtc.org/2306433002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java (right): https://codereview.webrtc.org/2306433002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java#newcode885 webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:885: } do you need an early return or ...
4 years, 3 months ago (2016-09-01 06:38:43 UTC) #7
AlexG
On 2016/09/01 06:38:43, wzh wrote: > lgtm > > https://codereview.webrtc.org/2306433002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java > File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java > (right): ...
4 years, 3 months ago (2016-09-01 18:40:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306433002/1
4 years, 3 months ago (2016-09-01 18:42:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 18:49:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 18:49:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a70856c0bf7e2817a68b82bdb131cfdd608d18f3
Cr-Commit-Position: refs/heads/master@{#14028}

Powered by Google App Engine
This is Rietveld 408576698