MB: Copy MB from Chromium repo

MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl --gyp-script=webrtc/build/gyp_webrtc.py //out/Release

Committed: https://crrev.com/a013a02e013bef7a317cd2950539f4436c3ff2ba
Cr-Commit-Position: refs/heads/master@{#15068}

[kjellander_webrtc, 2016-09-02 18:36:43]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ updated
to WebRTC's license.
It is needed so Chromium can start removing GYP support from
its own copy.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ updated
to WebRTC's license.
It is needed so Chromium can start removing GYP support from
its own copy.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
==========

[kjellander_webrtc, 2016-09-02 18:36:43]

kjellander@webrtc.org changed reviewers:
+ dpranke@chromium.org, ehmaldonado@webrtc.org

[kjellander_webrtc, 2016-09-02 18:39:21]

Patchset #1 (id:1) has been deleted

[ehmaldonado_webrtc, 2016-11-14 10:46:32]

On 2016/09/02 18:39:21, kjellander_webrtc wrote:
> Patchset #1 (id:1) has been deleted

Maybe it's time to try this again?

[kjellander_webrtc, 2016-11-14 10:54:04]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ updated
to WebRTC's license.
It is needed so Chromium can start removing GYP support from
its own copy.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
==========

[kjellander_webrtc, 2016-11-14 10:54:33]

On 2016/11/14 10:46:32, ehmaldonado_webrtc wrote:
> On 2016/09/02 18:39:21, kjellander_webrtc wrote:
> > Patchset #1 (id:1) has been deleted
> 
> Maybe it's time to try this again?

Yes. Rebased+updated to more recent MB.

[kjellander_webrtc, 2016-11-14 10:57:23]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[kjellander_webrtc, 2016-11-14 11:18:38]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[kjellander_webrtc, 2016-11-14 13:32:42]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510,chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[kjellander_webrtc, 2016-11-14 13:49:40]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:589510,chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[ehmaldonado_webrtc, 2016-11-14 13:50:01]

On 2016/11/14 10:54:33, kjellander_webrtc wrote:
> On 2016/11/14 10:46:32, ehmaldonado_webrtc wrote:
> > On 2016/09/02 18:39:21, kjellander_webrtc wrote:
> > > Patchset #1 (id:1) has been deleted
> > 
> > Maybe it's time to try this again?
> 
> Yes. Rebased+updated to more recent MB.

Awesome! LGTM

[kjellander_webrtc, 2016-11-14 13:50:36]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of
https://codereview.chromium.org/2299953002/ 
to WebRTC's license + updates up to Chromium
http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/ 
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[kjellander_webrtc, 2016-11-14 13:50:55]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-11-14 13:51:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-14 13:54:24]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/ 
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/ 
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

[commit-bot: I haz the power, 2016-11-14 13:54:25]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-14 13:54:32]

Description was changed from

==========
MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/ 
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release
==========

to

==========
MB: Copy MB from Chromium repo

Essentially a copy of https://codereview.chromium.org/2299953002/
plus changes to WebRTC's license, changed OWNERS and additional
MB updates up to Chromium revision http://crrev.com/f1e2718a3ff.

The PRESUBMIT.py check was updated to use the existing
webrtc/build/mb_config.pyl to avoid breaking bots (that have
this path hardcoded).

This replaces the previously symlinked MB, which already
runs validation of the WebRTC configs as part of
webrtc/build/PRESUBMIT.py.

BUG=chromium:664425
NOTRY=True
TESTED=Ran:
tools/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file
webrtc/build/mb_config.pyl --isolate-map-file=webrtc/build/gn_isolate_map.pyl
--gyp-script=webrtc/build/gyp_webrtc.py //out/Release

Committed: https://crrev.com/a013a02e013bef7a317cd2950539f4436c3ff2ba
Cr-Commit-Position: refs/heads/master@{#15068}
==========

[commit-bot: I haz the power, 2016-11-14 13:54:35]

Patchset 2 (id:??) landed as
https://crrev.com/a013a02e013bef7a317cd2950539f4436c3ff2ba
Cr-Commit-Position: refs/heads/master@{#15068}

[Dirk Pranke, 2016-11-14 17:40:25]

lgtm. 

I believe you were the only non-Chromium repo still using Chromium's copy of MB,
so I'll likely start ripping out the GYP support (which I'm not sure you even
still needed?) as time permits.

[kjellander_webrtc, 2016-11-14 21:14:50]

On 2016/11/14 17:40:25, Dirk Pranke wrote:
> lgtm. 
> 
> I believe you were the only non-Chromium repo still using Chromium's copy of
MB,
> so I'll likely start ripping out the GYP support (which I'm not sure you even
> still needed?) as time permits.

Please do. We can always pull in your cleanup into our copy since we don't plan
to modify it that much.
We'll remove our last pieces of GYP this week, is the plan.