Adding basic implementation of AudioNetworkAdaptor.

webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b86afdaccaedbcfdeceded5e0d32826aec3a8369
--- /dev/null
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
@@ -0,0 +1,112 @@
+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include <utility>
+#include <vector>
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h"
+#include "webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_controller.h"
+#include "webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_controller_manager.h"
+
+namespace webrtc {
+
+using ::testing::_;
+using ::testing::NiceMock;
+using ::testing::Return;
+
+namespace {
+
+constexpr size_t kNumControllers = 2;
+
+MATCHER_P(NetworkMetricsIs, metric, "") {
+  return arg.uplink_bandwidth_bps == metric.uplink_bandwidth_bps &&
+         arg.uplink_packet_loss_fraction == metric.uplink_packet_loss_fraction;
+}
+
+MATCHER_P(ConstraintsReceiverFrameLengthRangeIs, frame_length_range, "") {
+  return arg.receiver_frame_length_range->min_frame_length_ms ==
+             frame_length_range.min_frame_length_ms &&
+         arg.receiver_frame_length_range->max_frame_length_ms ==
+             frame_length_range.max_frame_length_ms;
+}
+
+}  // namespace
+
+class AudioNetworkAdaptorImplTest : public ::testing::Test {
+ protected:
+  AudioNetworkAdaptorImplTest()
+      : audio_network_adaptor_(nullptr), mock_controller_manager_(nullptr) {}

[kwiberg-webrtc, 2016/09/09 11:56:15]

Initialize these down where you declare them instead---that should be more
readable. (Also, you don't need to initialize unique_ptrs, since they're always
initialized to null.)

[minyue-webrtc, 2016/09/12 11:36:11]

Done.

+
+  void SetUp() override {
+    std::vector<Controller*> controllers;
+    for (size_t i = 0; i < kNumControllers; ++i) {
+      auto controller =
+          std::unique_ptr<MockController>(new NiceMock<MockController>());
+      EXPECT_CALL(*controller, Die());
+      controllers.push_back(controller.get());
+      mock_controllers_.push_back(std::move(controller));
+    }
+
+    auto controller_manager = std::unique_ptr<MockControllerManager>(
+        new NiceMock<MockControllerManager>());
+
+    mock_controller_manager_ = controller_manager.get();
+    EXPECT_CALL(*mock_controller_manager_, Die());
+    EXPECT_CALL(*mock_controller_manager_, GetControllers())
+        .WillRepeatedly(Return(controllers));
+    EXPECT_CALL(*mock_controller_manager_, GetSortedControllers(_))
+        .WillRepeatedly(Return(controllers));
+
+    // AudioNetworkAdaptorImpl governs the lifetime of controller manager.
+    audio_network_adaptor_.reset(new AudioNetworkAdaptorImpl(
+        AudioNetworkAdaptorImpl::Config(), std::move(controller_manager)));
+  }
+
+  std::unique_ptr<AudioNetworkAdaptorImpl> audio_network_adaptor_;
+
+  MockControllerManager* mock_controller_manager_;
+
+  std::vector<std::unique_ptr<MockController>> mock_controllers_;
+};

[kwiberg-webrtc, 2016/09/09 11:56:15]

It'd be easier to read the tests if you skipped the fixture, and replaced it
with a free function that returned a struct with the stuff you need. That way,
there are fewer (potential) indirections to keep track of, and the test uses
only local variables.

[minyue-webrtc, 2016/09/12 11:36:11]

Done.

+
+TEST_F(AudioNetworkAdaptorImplTest,
+       MakeDecisionIsCalledOnGetEncoderRuntimeConfig) {
+  constexpr int kBandwidth = 16000;
+  constexpr float kPacketLoss = 0.7f;
+
+  Controller::NetworkMetrics check;
+  check.uplink_bandwidth_bps = rtc::Optional<int>(kBandwidth);
+
+  for (auto& mock_controller : mock_controllers_) {
+    EXPECT_CALL(*mock_controller, MakeDecision(NetworkMetricsIs(check), _));
+  }
+  audio_network_adaptor_->SetUplinkBandwidth(kBandwidth);
+  audio_network_adaptor_->GetEncoderRuntimeConfig();
+
+  check.uplink_packet_loss_fraction = rtc::Optional<float>(kPacketLoss);
+  for (auto& mock_controller : mock_controllers_) {
+    EXPECT_CALL(*mock_controller, MakeDecision(NetworkMetricsIs(check), _));
+  }
+  audio_network_adaptor_->SetUplinkPacketLossFraction(kPacketLoss);
+  audio_network_adaptor_->GetEncoderRuntimeConfig();
+}
+
+TEST_F(AudioNetworkAdaptorImplTest,
+       SetConstraintsIsCalledOnSetFrameLengthRange) {
+  for (auto& mock_controller : mock_controllers_) {
+    EXPECT_CALL(*mock_controller,
+                SetConstraints(ConstraintsReceiverFrameLengthRangeIs(
+                    Controller::Constraints::FrameLengthRange(20, 120))));
+  }
+  audio_network_adaptor_->SetReceiverFrameLengthRange(20, 120);
+}
+
+}  // namespace webrtc