Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2306013002: Remove restart method from VideoTrackSourceInterface. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove restart method from VideoTrackSourceInterface. This method is no longer needed. Committed: https://crrev.com/a973f953863608dab7ac82b35df08cac499a2b0f Cr-Commit-Position: refs/heads/master@{#14060} BUG=webrtc:6318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M webrtc/api/androidvideotracksource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videotracksource.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-02 11:33:26 UTC) #5
magjed_webrtc
lgtm. As a follow-up, remove the C++ VideoTrackSourceInterface::Restart().
4 years, 3 months ago (2016-09-02 12:38:58 UTC) #6
sakal
On 2016/09/02 12:38:58, magjed_webrtc wrote: > lgtm. As a follow-up, remove the C++ VideoTrackSourceInterface::Restart(). This ...
4 years, 3 months ago (2016-09-02 12:40:37 UTC) #8
tommi
lgtm
4 years, 3 months ago (2016-09-02 15:43:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306013002/40001
4 years, 3 months ago (2016-09-03 16:46:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-09-03 17:29:11 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 17:29:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a973f953863608dab7ac82b35df08cac499a2b0f
Cr-Commit-Position: refs/heads/master@{#14060}

Powered by Google App Engine
This is Rietveld 408576698