Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

Issue 2305793003: Simplify public interface of ProducerFec. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
index b8885ef3b16d086925cc2376d4b4ec72f6a1588a..122dfb095137df61ba1ffa34db501163020359de 100644
--- a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
@@ -122,12 +122,12 @@ TEST_F(ProducerFecTest, OneFrameFec) {
last_timestamp = packet->header.header.timestamp;
packets.push_back(std::move(packet));
}
- EXPECT_TRUE(producer_.FecAvailable());
+ EXPECT_GT(producer_.NumAvailableFecPackets(), 0u);
uint16_t seq_num = packet_generator_.NextSeqNum();
std::vector<std::unique_ptr<RedPacket>> red_packets =
producer_.GetFecPacketsAsRed(kRedPayloadType, kFecPayloadType, seq_num,
kRtpHeaderSize);
- EXPECT_FALSE(producer_.FecAvailable());
+ EXPECT_EQ(producer_.NumAvailableFecPackets(), 0u);
ASSERT_EQ(1u, red_packets.size());
VerifyHeader(seq_num, last_timestamp, kRedPayloadType, kFecPayloadType,
red_packets.front().get(), false);
@@ -159,12 +159,12 @@ TEST_F(ProducerFecTest, TwoFrameFec) {
packets.push_back(std::move(packet));
}
}
- EXPECT_TRUE(producer_.FecAvailable());
+ EXPECT_GT(producer_.NumAvailableFecPackets(), 0u);
uint16_t seq_num = packet_generator_.NextSeqNum();
std::vector<std::unique_ptr<RedPacket>> red_packets =
producer_.GetFecPacketsAsRed(kRedPayloadType, kFecPayloadType, seq_num,
kRtpHeaderSize);
- EXPECT_FALSE(producer_.FecAvailable());
+ EXPECT_EQ(producer_.NumAvailableFecPackets(), 0u);
ASSERT_EQ(1u, red_packets.size());
VerifyHeader(seq_num, last_timestamp, kRedPayloadType, kFecPayloadType,
red_packets.front().get(), false);

Powered by Google App Engine
This is Rietveld 408576698