Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2305643002: Fix gn build of stun_prober (Closed)

Created:
4 years, 3 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix gn build of stun_prober The common_config must be included in order for LOG to work within Chrome. Otherwise you get compile errors... See https://codereview.chromium.org/2300923002/ TBR=pthatcher@webrtc.org Committed: https://crrev.com/671d8008be4a8725e34dc0098ac3a2aa75f6b4a7 Cr-Commit-Position: refs/heads/master@{#14020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
perkj_webrtc
4 years, 3 months ago (2016-09-01 12:53:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
671d8008be4a8725e34dc0098ac3a2aa75f6b4a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698