Add option to skip rects to drawImageLattice()

Add option to skip rects to drawImageLattice()

HWUI skips transparent rects when drawing.

When skia draws using bilerp, we will blend
transparent rects with neighboring rects and might
draw a bit of a smudge.

This CL adds the option to skip rects, allowing us
to have compatible behavior with the framework.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002

Committed: https://skia.googlesource.com/skia/+/0764efe6a9ae65ad83992f614f57ca9db5b1f191

[msarett, 2016-08-31 22:12:47]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

BUG=skia:
==========

to

==========
Add option to skip rects to drawImageLattice()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[msarett, 2016-08-31 22:39:08]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects to drawImageLattice()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[msarett, 2016-08-31 22:40:22]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects to drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[msarett, 2016-08-31 22:40:44]

msarett@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com, reed@google.com

[msarett, 2016-09-01 03:19:32]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects on drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[msarett, 2016-09-01 13:11:51]

Description was changed from

==========
Add option to skip rects on drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects to drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[msarett, 2016-09-01 13:13:33]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

When using bilerp, we will blend transparent rects
with neighboring rects and draw a bit of a smudge.

Better to skip transparent rects, just like hwui does.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects to drawImageLattice()

HWUI skips transparent rects when drawing.

When skia draws using bilerp, we will blend
transparent rects with neighboring rects and might
draw a bit of a smudge.

This CL adds the option to skip rects, allowing us
to have compatible behavior with the framework.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

[mtklein, 2016-09-01 13:20:50]

All the recordy stuff lgtm

[reed1, 2016-09-01 14:15:24]

packing nit:

int*
int*
char*
int
int

packs a little nicer on 64bit machines than what we have today.

https://codereview.chromium.org/2305433002/diff/30001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2305433002/diff/30001/include/core/SkCanvas.h...
include/core/SkCanvas.h:967: int          fFlagCount;
Lets try not having this, and just documenting that fFlags must be (xdivs +
1)*(ydivs + 1) long...?

[msarett, 2016-09-01 16:27:24]

Removed fFlagCount from the Lattice struct.  This requires
a little extra thinking in SkLatticeIter and on the
framework side, but I think the API is cleaner and less
redundant.

https://codereview.chromium.org/2305433002/diff/30001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2305433002/diff/30001/include/core/SkCanvas.h...
include/core/SkCanvas.h:967: int          fFlagCount;
On 2016/09/01 14:15:23, reed1 wrote:
> Lets try not having this, and just documenting that fFlags must be (xdivs +
> 1)*(ydivs + 1) long...?

SGTM

https://codereview.chromium.org/2305433002/diff/50001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2305433002/diff/50001/include/core/SkCanvas.h...
include/core/SkCanvas.h:943: // These must be unique, increasing, and in the set
[0, width).
Notice subtle change here.  Width and height are no longer valid divs.

[reed1, 2016-09-01 17:25:56]

lgtm

[msarett, 2016-09-01 17:41:46]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:41:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:04:18]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-01 23:55:11]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:55:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:44:23]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-02 16:55:27]

Patchset #6 (id:90001) has been deleted

[msarett, 2016-09-02 16:55:35]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 16:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:22:04]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-09-02 17:27:31]

The CQ bit was checked by msarett@google.com

[msarett, 2016-09-02 17:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2305433002/#ps110001
(title: "Better detection for zero divs")

[commit-bot: I haz the power, 2016-09-02 17:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 18:24:42]

Description was changed from

==========
Add option to skip rects to drawImageLattice()

HWUI skips transparent rects when drawing.

When skia draws using bilerp, we will blend
transparent rects with neighboring rects and might
draw a bit of a smudge.

This CL adds the option to skip rects, allowing us
to have compatible behavior with the framework.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002
==========

to

==========
Add option to skip rects to drawImageLattice()

HWUI skips transparent rects when drawing.

When skia draws using bilerp, we will blend
transparent rects with neighboring rects and might
draw a bit of a smudge.

This CL adds the option to skip rects, allowing us
to have compatible behavior with the framework.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2305433002

Committed:
https://skia.googlesource.com/skia/+/0764efe6a9ae65ad83992f614f57ca9db5b1f191
==========

[commit-bot: I haz the power, 2016-09-02 18:24:43]

Committed patchset #6 (id:110001) as
https://skia.googlesource.com/skia/+/0764efe6a9ae65ad83992f614f57ca9db5b1f191