Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)
Patch Set: Make all regex strings raw strings. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
index 13862597f78e59cc74feaec3648cd6dfdf7e5b47..612ebdb323f769749fd8c301fb9ccc1c87350aff 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
@@ -313,7 +313,7 @@ class AndroidCommands(object):
@staticmethod
def _determine_adb_version(adb_command_path, executive, debug_logging):
- re_version = re.compile('^.*version ([\d\.]+)')
+ re_version = re.compile(r'^.*version ([\d\.]+)')
try:
output = executive.run_command([adb_command_path, 'version'], error_handler=executive.ignore_error,
debug_logging=debug_logging)
@@ -356,7 +356,7 @@ class AndroidDevices(object):
# Example "adb devices" command output:
# List of devices attached
# 0123456789ABCDEF device
- re_device = re.compile('^([a-zA-Z0-9_:.-]+)\tdevice$', re.MULTILINE)
+ re_device = re.compile(r'^([a-zA-Z0-9_:.-]+)\tdevice$', re.MULTILINE)
result = executive.run_command([AndroidCommands.adb_command_path(executive, debug_logging=self._debug_logging), 'devices'],
error_handler=executive.ignore_error, debug_logging=self._debug_logging)
@@ -399,7 +399,7 @@ class AndroidDevices(object):
_log.warning('Unable to read the battery level from device with serial "%s".', commands.get_serial())
return 0
- return int(re.findall('level: (\d+)', battery_status)[0])
+ return int(re.findall(r'level: (\d+)', battery_status)[0])
def _is_device_screen_on(self, commands):
power_status = commands.run(['shell', 'dumpsys', 'power'])
@@ -760,7 +760,7 @@ http://goto.google.com/cr-android-perf-howto
return self._cached_perf_host_path
def _first_ten_lines_of_profile(self, perf_output):
- match = re.search("^#[^\n]*\n((?: [^\n]*\n){1,10})", perf_output, re.MULTILINE)
+ match = re.search(r"^#[^\n]*\n((?: [^\n]*\n){1,10})", perf_output, re.MULTILINE)
return match.group(1) if match else None
def profile_after_exit(self):

Powered by Google App Engine
This is Rietveld 408576698