Update PRESUBMIT.py to handle GN.

Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True

Committed: https://crrev.com/5b1ba0857bba4179b60de1e6f9c887704fd28e8a
Cr-Commit-Position: refs/heads/master@{#14046}

[ehmaldonado_webrtc, 2016-09-02 09:32:17]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 09:32:18]

https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py#newcode271
PRESUBMIT.py:271: # This are not in GYP, but were in GN at the time of writing
this
What should we do with these files?

[kjellander_webrtc, 2016-09-02 12:13:22]

Nice work, I don't see any errors but did you test it with two violating changes
in a local commit to see that the new rules are actually working?

lgtm if so.

https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py#newcode271
PRESUBMIT.py:271: # This are not in GYP, but were in GN at the time of writing
this
On 2016/09/02 09:32:18, ehmaldonado_webrtc wrote:
> What should we do with these files?

Leave them as is and add a reference to
https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 here. It's a cleanup
that will have to be done at some point in the future. For now the important
thing is that we don't make things worse at least (which this PRESUBMIT check
somewhat prevents).

[ehmaldonado_webrtc, 2016-09-02 12:31:00]

On 2016/09/02 12:13:22, kjellander_webrtc wrote:
> Nice work, I don't see any errors but did you test it with two violating
changes
> in a local commit to see that the new rules are actually working?
> 
> lgtm if so.
> 
> https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.webrtc.org/2304883002/diff/1/PRESUBMIT.py#newcode271
> PRESUBMIT.py:271: # This are not in GYP, but were in GN at the time of writing
> this
> On 2016/09/02 09:32:18, ehmaldonado_webrtc wrote:
> > What should we do with these files?
> 
> Leave them as is and add a reference to
> https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 here. It's a cleanup
> that will have to be done at some point in the future. For now the important
> thing is that we don't make things worse at least (which this PRESUBMIT check
> somewhat prevents).

Yes, I tested.

[ehmaldonado_webrtc, 2016-09-02 12:34:20]

Description was changed from

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
==========

to

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-09-02 12:34:26]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 12:34:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2304883002/#ps20001 (title:
"Updated comments.")

[commit-bot: I haz the power, 2016-09-02 12:34:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 12:51:12]

Description was changed from

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True
==========

to

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-02 12:51:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 12:51:23]

Description was changed from

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True
==========

to

==========
Update PRESUBMIT.py to handle GN.

- Check that no target references sources with paths above the GN file location.
- Chcek that no target depends on rtc_base.

BUG=webrtc:6294
NOTRY=True

Committed: https://crrev.com/5b1ba0857bba4179b60de1e6f9c887704fd28e8a
Cr-Commit-Position: refs/heads/master@{#14046}
==========

[commit-bot: I haz the power, 2016-09-02 12:51:24]

Patchset 2 (id:??) landed as
https://crrev.com/5b1ba0857bba4179b60de1e6f9c887704fd28e8a
Cr-Commit-Position: refs/heads/master@{#14046}