Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: webrtc/modules/video_coding/rtp_frame_reference_finder.h

Issue 2304723004: Added ClearTo(seq_num) to RtpFrameReferenceFinder. (Closed)
Patch Set: Added comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/rtp_frame_reference_finder.h
diff --git a/webrtc/modules/video_coding/rtp_frame_reference_finder.h b/webrtc/modules/video_coding/rtp_frame_reference_finder.h
index a812303b7ea85eea4e1a02992322f22473743367..cdc9ce8c092db7171bacd95910be7ca770133091 100644
--- a/webrtc/modules/video_coding/rtp_frame_reference_finder.h
+++ b/webrtc/modules/video_coding/rtp_frame_reference_finder.h
@@ -40,9 +40,17 @@ class OnCompleteFrameCallback {
class RtpFrameReferenceFinder {
public:
explicit RtpFrameReferenceFinder(OnCompleteFrameCallback* frame_callback);
+
+ // Find all references for this frame.
stefan-webrtc 2016/09/07 13:29:57 Maybe the method should be called that in stead of
philipel 2016/09/08 11:27:19 Updated the comment the better reflect what Manage
void ManageFrame(std::unique_ptr<RtpFrameObject> frame);
+
+ // Notifies that padding has been received, which the reference finder
+ // might need to calculate the references of a frame.
void PaddingReceived(uint16_t seq_num);
+ // Clear all stashed frames that include packets older than |seq_num|.
+ void ClearTo(uint16_t seq_num);
+
private:
static const uint16_t kPicIdLength = 1 << 7;
static const uint8_t kMaxTemporalLayers = 5;
@@ -177,6 +185,11 @@ class RtpFrameReferenceFinder {
kMaxTemporalLayers>
missing_frames_for_layer_ GUARDED_BY(crit_);
+ // How far frames have been cleared by sequence number. A frame will be
+ // cleared if it contains a packet with a sequence number older than
+ // |cleared_to_seq_num_|.
+ int cleared_to_seq_num_ GUARDED_BY(crit_);
+
OnCompleteFrameCallback* frame_callback_;
};

Powered by Google App Engine
This is Rietveld 408576698