Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2304603002: Change SimulcastEncoderAdapter to allow a 0 for SetRates. (Closed)

Created:
4 years, 3 months ago by noahric
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
mflodman, stefan-webrtc, tterriberry_mozilla.com, video-team_agora.io, webrtc-reviews_webrtc.org, zhengzhonghou_agora.io
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change SimulcastEncoderAdapter to allow a 0 for SetRates. 0 means "pause", so forcing it to the min bitrate means we'll never allow pausing for internal source encoders. BUG= Committed: https://crrev.com/fac0ff022bbe4f01fd37ac8b5416b1e30c5be295 Cr-Commit-Position: refs/heads/master@{#14168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
noahric
4 years, 3 months ago (2016-09-01 20:13:03 UTC) #2
mflodman
lgtm
4 years, 3 months ago (2016-09-02 08:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2304603002/1
4 years, 3 months ago (2016-09-06 22:01:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16401)
4 years, 3 months ago (2016-09-06 22:44:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2304603002/1
4 years, 3 months ago (2016-09-06 22:45:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-07 00:02:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2304603002/1
4 years, 3 months ago (2016-09-07 22:21:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16324)
4 years, 3 months ago (2016-09-07 22:55:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2304603002/1
4 years, 3 months ago (2016-09-08 17:08:24 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-08 19:08:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2304603002/1
4 years, 3 months ago (2016-09-09 16:58:55 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 17:27:18 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:27:26 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac0ff022bbe4f01fd37ac8b5416b1e30c5be295
Cr-Commit-Position: refs/heads/master@{#14168}

Powered by Google App Engine
This is Rietveld 408576698