|
|
DescriptionChange SimulcastEncoderAdapter to allow a 0 for SetRates.
0 means "pause", so forcing it to the min bitrate means we'll never
allow pausing for internal source encoders.
BUG=
Committed: https://crrev.com/fac0ff022bbe4f01fd37ac8b5416b1e30c5be295
Cr-Commit-Position: refs/heads/master@{#14168}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
noahric@chromium.org changed reviewers: + mflodman@webrtc.org, stefan@webrtc.org
lgtm
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16401)
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16324)
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change SimulcastEncoderAdapter to allow a 0 for SetRates. 0 means "pause", so forcing it to the min bitrate means we'll never allow pausing for internal source encoders. BUG= ========== to ========== Change SimulcastEncoderAdapter to allow a 0 for SetRates. 0 means "pause", so forcing it to the min bitrate means we'll never allow pausing for internal source encoders. BUG= Committed: https://crrev.com/fac0ff022bbe4f01fd37ac8b5416b1e30c5be295 Cr-Commit-Position: refs/heads/master@{#14168} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fac0ff022bbe4f01fd37ac8b5416b1e30c5be295 Cr-Commit-Position: refs/heads/master@{#14168} |