webrtc/modules/audio_processing/gain_control_impl.h - Issue 2304123002: Cleaned up and revised the handling of resampling and bandsplitting in APM and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/gain_control_impl.h

Issue 2304123002: Cleaned up and revised the handling of resampling and bandsplitting in APM and (Closed)

Patch Set: Updated the test that required that no initialization should be done if APM is called with the defa… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/gain_control_impl.h

diff --git a/webrtc/modules/audio_processing/gain_control_impl.h b/webrtc/modules/audio_processing/gain_control_impl.h

index 2459ce3b4b7e943412d2d6c7608a1be24edef48c..1af6d7b246e8048f066f10af7325edfc47e040a5 100644

--- a/webrtc/modules/audio_processing/gain_control_impl.h

+++ b/webrtc/modules/audio_processing/gain_control_impl.h

@@ -43,11 +43,6 @@ class GainControlImpl : public GainControl {

bool is_limiter_enabled() const override;

Mode mode() const override;

- // Checks whether the module is enabled. Must only be

- // called from the render side of APM as otherwise

- // deadlocks may occur.

- bool is_enabled_render_side_query() const;

// Reads render side data that has been queued on the render call.

void ReadQueuedRenderData();