webrtc/modules/audio_processing/echo_cancellation_impl.cc - Issue 2304123002: Cleaned up and revised the handling of resampling and bandsplitting in APM and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.cc

Issue 2304123002: Cleaned up and revised the handling of resampling and bandsplitting in APM and (Closed)

Patch Set: Updated the test that required that no initialization should be done if APM is called with the defa… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/echo_cancellation_impl.cc

diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.cc b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

index 5a7aef6fdf970e2b8cae8e779df6298b9552efa6..f18c1c3f8a46aaa1d77b93ec87f687e23909c51a 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_impl.cc

+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

@@ -275,12 +275,6 @@ int EchoCancellationImpl::Enable(bool enable) {

return AudioProcessing::kNoError;

}

-bool EchoCancellationImpl::is_enabled_render_side_query() const {

- // TODO(peah): Add threadchecker.

- rtc::CritScope cs_render(crit_render_);

- return enabled_;

bool EchoCancellationImpl::is_enabled() const {

rtc::CritScope cs(crit_capture_);

return enabled_;