Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2303893002:
Limit initial fps value used in Android HW encoder initialization. (Closed)
DescriptionLimit initial fps value used in Android HW encoder initialization.
BUG=b/30951236
R=magjed@webrtc.org, wzh@webrtc.org
Committed: https://crrev.com/c55c39ddf7aa26e15a5e375a92fd16205ce502cf
Cr-Commit-Position: refs/heads/master@{#14054}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Address comments #Messages
Total messages: 18 (11 generated)
glaznev@webrtc.org changed reviewers: + wzh@webrtc.org
PTAL
Description was changed from ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 ========== to ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 ==========
The CQ bit was checked by glaznev@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
lgtm https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:382: fps = (fps < MAXIMUM_INITIAL_FPS) ? fps : MAXIMUM_INITIAL_FPS; nit: fps = Math.max(fps, MAXIMUM_INITIAL_FPS);
magjed@webrtc.org changed reviewers: + magjed@webrtc.org
lgtm https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:382: fps = (fps < MAXIMUM_INITIAL_FPS) ? fps : MAXIMUM_INITIAL_FPS; On 2016/09/02 00:20:42, wzh wrote: > nit: fps = Math.max(fps, MAXIMUM_INITIAL_FPS); nit: fps = Math.min(fps, MAXIMUM_INITIAL_FPS);
https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2303893002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:382: fps = (fps < MAXIMUM_INITIAL_FPS) ? fps : MAXIMUM_INITIAL_FPS; On 2016/09/02 08:48:28, magjed_webrtc wrote: > On 2016/09/02 00:20:42, wzh wrote: > > nit: fps = Math.max(fps, MAXIMUM_INITIAL_FPS); > > nit: fps = Math.min(fps, MAXIMUM_INITIAL_FPS); Done.
The CQ bit was checked by glaznev@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org, wzh@webrtc.org Link to the patchset: https://codereview.webrtc.org/2303893002/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 ========== to ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 R=magjed@webrtc.org, wzh@webrtc.org Committed: https://crrev.com/c55c39ddf7aa26e15a5e375a92fd16205ce502cf Cr-Commit-Position: refs/heads/master@{#14054} ==========
Message was sent while issue was closed.
Description was changed from ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 R=magjed@webrtc.org, wzh@webrtc.org Committed: https://crrev.com/c55c39ddf7aa26e15a5e375a92fd16205ce502cf Cr-Commit-Position: refs/heads/master@{#14054} ========== to ========== Limit initial fps value used in Android HW encoder initialization. BUG=b/30951236 R=magjed@webrtc.org, wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c55c39ddf7aa26e15a5e375a9... ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c55c39ddf7aa26e15a5e375a92fd16205ce502cf Cr-Commit-Position: refs/heads/master@{#14054}
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as c55c39ddf7aa26e15a5e375a92fd16205ce502cf (presubmit successful). |
