Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: webrtc/p2p/BUILD.gn

Issue 2303783002: Do not build stun_prober within Chrome on gn. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/BUILD.gn
diff --git a/webrtc/p2p/BUILD.gn b/webrtc/p2p/BUILD.gn
index 7866f0aee860f2db2246bf6637c73eaaaefbea5f..5f0f5220b4dc16503dcfda3a097cb051510a41e5 100644
--- a/webrtc/p2p/BUILD.gn
+++ b/webrtc/p2p/BUILD.gn
@@ -163,21 +163,25 @@ source_set("libstunprober") {
]
}
-executable("stun_prober") {
- sources = [
- "stunprober/main.cc",
- ]
+if (!build_with_chromium) {
+ # Doesn't build within Chrome on Win.
- configs += [ "..:common_config" ]
- if (!build_with_chromium && is_clang) {
- # Suppress warnings from Chrome's Clang plugins.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
- configs -= [ "//build/config/clang:find_bad_constructs" ]
- }
+ executable("stun_prober") {
+ sources = [
+ "stunprober/main.cc",
+ ]
- deps = [
- ":libstunprober",
- ":rtc_p2p",
- "../system_wrappers:field_trial_default",
- ]
+ configs += [ "..:common_config" ]
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from Chrome's Clang plugins.
+ # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ configs -= [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ ":libstunprober",
+ ":rtc_p2p",
+ "../system_wrappers:field_trial_default",
+ ]
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698