Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2303783002: Do not build stun_prober within Chrome on gn. (Closed)

Created:
4 years, 3 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not build stun_prober within Chrome on gn. stun_prober does not compile on win. https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/79068/steps/compile%20%28with%20patch%29/logs/stdio TBR=pthatcher@webrtc.org BUG= Committed: https://crrev.com/3f9dd7c0cc0df1d1e83642163a9eecc0c99a863a Cr-Commit-Position: refs/heads/master@{#14024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +19 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
perkj_webrtc
Committed patchset #1 (id:1) manually as 3f9dd7c0cc0df1d1e83642163a9eecc0c99a863a (presubmit successful).
4 years, 3 months ago (2016-09-01 15:06:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f9dd7c0cc0df1d1e83642163a9eecc0c99a863a Cr-Commit-Position: refs/heads/master@{#14024}
4 years, 3 months ago (2016-09-01 15:06:15 UTC) #4
perkj_webrtc
4 years, 3 months ago (2016-09-01 15:07:33 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698