Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2303763002: Use RateCounter for received bitrate stats. (Closed)

Created:
4 years, 3 months ago by åsapersson
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 Committed: https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc Cr-Commit-Position: refs/heads/master@{#14119}

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : address comment #

Patch Set 4 : remove unneeded checks #

Patch Set 5 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -35 lines) Patch
M webrtc/call/call.cc View 1 2 3 4 7 chunks +37 lines, -35 lines 0 comments Download
M webrtc/video/stats_counter.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/stats_counter.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/stats_counter_unittest.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
stefan-webrtc
https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newcode182 webrtc/call/call.cc:182: int64_t received_rtcp_bytes_; Should we do the same thing for ...
4 years, 3 months ago (2016-09-06 11:55:58 UTC) #3
åsapersson
https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newcode182 webrtc/call/call.cc:182: int64_t received_rtcp_bytes_; On 2016/09/06 11:55:58, stefan-webrtc (holmer) wrote: > ...
4 years, 3 months ago (2016-09-06 15:13:23 UTC) #11
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-07 13:37:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2303763002/160001
4 years, 3 months ago (2016-09-08 05:51:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/405)
4 years, 3 months ago (2016-09-08 05:55:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2303763002/180001
4 years, 3 months ago (2016-09-08 06:13:38 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 3 months ago (2016-09-08 07:07:27 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 07:07:35 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc
Cr-Commit-Position: refs/heads/master@{#14119}

Powered by Google App Engine
This is Rietveld 408576698