Use RateCounter for received bitrate stats.

Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates.

BUG=webrtc:5283
Committed: https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc
Cr-Commit-Position: refs/heads/master@{#14119}

[åsapersson, 2016-09-05 08:51:19]

Description was changed from

==========
Use RateCounter for received bitrate stats
("WebRTC.Call.BitrateReceivedInKbps").

Reports the average of periodically computed bitrates over a call (2 sec
interval). Intervals without bytes are excluded and will no longer affect the
stats (a total rate over the call was previously computed). May cause the stats
to increase.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats
("WebRTC.Call.BitrateReceivedInKbps").

Reports the average of periodically computed bitrates over a call (2 sec
interval). Intervals without bytes are excluded and will no longer affect the
stats (a total rate over the call was previously computed). May cause the stats
to increase.

BUG=webrtc:5283
==========

[åsapersson, 2016-09-05 08:51:19]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-09-06 11:55:58]

https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newco...
webrtc/call/call.cc:182: int64_t received_rtcp_bytes_;
Should we do the same thing for these three? In that case maybe they can replace
the new RateCounter too?

[åsapersson, 2016-09-06 14:08:49]

Patchset #3 (id:40001) has been deleted

[åsapersson, 2016-09-06 14:39:18]

Patchset #4 (id:80001) has been deleted

[åsapersson, 2016-09-06 14:40:52]

Patchset #3 (id:60001) has been deleted

[åsapersson, 2016-09-06 14:59:32]

Patchset #3 (id:100001) has been deleted

[åsapersson, 2016-09-06 15:03:18]

Description was changed from

==========
Use RateCounter for received bitrate stats
("WebRTC.Call.BitrateReceivedInKbps").

Reports the average of periodically computed bitrates over a call (2 sec
interval). Intervals without bytes are excluded and will no longer affect the
stats (a total rate over the call was previously computed). May cause the stats
to increase.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Periodic bitrates may be reported later.

BUG=webrtc:5283
==========

[åsapersson, 2016-09-06 15:06:10]

Description was changed from

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Periodic bitrates may be reported later.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). The periodic bitrates may be reported later.

BUG=webrtc:5283
==========

[åsapersson, 2016-09-06 15:11:23]

Description was changed from

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). The periodic bitrates may be reported later.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Adds possibility to later modify the stats and use/report the
periodic bitrates.

BUG=webrtc:5283
==========

[åsapersson, 2016-09-06 15:13:23]

https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newco...
webrtc/call/call.cc:182: int64_t received_rtcp_bytes_;
On 2016/09/06 11:55:58, stefan-webrtc (holmer) wrote:
> Should we do the same thing for these three? In that case maybe they can
replace
> the new RateCounter too?

Also updated video, audio and rctp stats to use RateCounter.

[åsapersson, 2016-09-07 06:53:37]

Patchset #3 (id:120001) has been deleted

[stefan-webrtc, 2016-09-07 13:37:00]

lgtm

[åsapersson, 2016-09-08 05:51:25]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-09-08 05:51:26]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2303763002/#ps160001 (title:
"remove unneeded checks")

[commit-bot: I haz the power, 2016-09-08 05:51:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 05:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 05:55:15]

Try jobs failed on following builders:
  win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/405)

[åsapersson, 2016-09-08 06:13:32]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-09-08 06:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2303763002/#ps180001 (title:
"fix warning")

[commit-bot: I haz the power, 2016-09-08 06:13:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 07:07:26]

Description was changed from

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Adds possibility to later modify the stats and use/report the
periodic bitrates.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Adds possibility to later modify the stats and use/report the
periodic bitrates.

BUG=webrtc:5283
==========

[commit-bot: I haz the power, 2016-09-08 07:07:27]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2016-09-08 07:07:33]

Description was changed from

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Adds possibility to later modify the stats and use/report the
periodic bitrates.

BUG=webrtc:5283
==========

to

==========
Use RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"

Reports the average of periodically computed bitrates over a call (2 sec
interval). Adds possibility to later modify the stats and use/report the
periodic bitrates.

BUG=webrtc:5283

Committed: https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc
Cr-Commit-Position: refs/heads/master@{#14119}
==========

[commit-bot: I haz the power, 2016-09-08 07:07:35]

Patchset 5 (id:??) landed as
https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc
Cr-Commit-Position: refs/heads/master@{#14119}