|
|
Created:
4 years, 3 months ago by åsapersson Modified:
4 years, 3 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUse RateCounter for received bitrate stats:
"WebRTC.Call.BitrateReceivedInKbps"
"WebRTC.Call.VideoBitrateReceivedInKbps"
"WebRTC.Call.AudioBitrateReceivedInKbps"
"WebRTC.Call.RtcpBitrateReceivedInBps"
Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates.
BUG=webrtc:5283
Committed: https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc
Cr-Commit-Position: refs/heads/master@{#14119}
Patch Set 1 #Patch Set 2 #
Total comments: 2
Patch Set 3 : address comment #Patch Set 4 : remove unneeded checks #Patch Set 5 : fix warning #
Created: 4 years, 3 months ago
Messages
Total messages: 25 (17 generated)
Description was changed from ========== Use RateCounter for received bitrate stats ("WebRTC.Call.BitrateReceivedInKbps"). Reports the average of periodically computed bitrates over a call (2 sec interval). Intervals without bytes are excluded and will no longer affect the stats (a total rate over the call was previously computed). May cause the stats to increase. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats ("WebRTC.Call.BitrateReceivedInKbps"). Reports the average of periodically computed bitrates over a call (2 sec interval). Intervals without bytes are excluded and will no longer affect the stats (a total rate over the call was previously computed). May cause the stats to increase. BUG=webrtc:5283 ==========
asapersson@webrtc.org changed reviewers: + stefan@webrtc.org
https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newco... webrtc/call/call.cc:182: int64_t received_rtcp_bytes_; Should we do the same thing for these three? In that case maybe they can replace the new RateCounter too?
Patchset #3 (id:40001) has been deleted
Patchset #4 (id:80001) has been deleted
Patchset #3 (id:60001) has been deleted
Patchset #3 (id:100001) has been deleted
Description was changed from ========== Use RateCounter for received bitrate stats ("WebRTC.Call.BitrateReceivedInKbps"). Reports the average of periodically computed bitrates over a call (2 sec interval). Intervals without bytes are excluded and will no longer affect the stats (a total rate over the call was previously computed). May cause the stats to increase. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Periodic bitrates may be reported later. BUG=webrtc:5283 ==========
Description was changed from ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Periodic bitrates may be reported later. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). The periodic bitrates may be reported later. BUG=webrtc:5283 ==========
Description was changed from ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). The periodic bitrates may be reported later. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 ==========
https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2303763002/diff/20001/webrtc/call/call.cc#newco... webrtc/call/call.cc:182: int64_t received_rtcp_bytes_; On 2016/09/06 11:55:58, stefan-webrtc (holmer) wrote: > Should we do the same thing for these three? In that case maybe they can replace > the new RateCounter too? Also updated video, audio and rctp stats to use RateCounter.
Patchset #3 (id:120001) has been deleted
lgtm
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2303763002/#ps160001 (title: "remove unneeded checks")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/405)
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2303763002/#ps180001 (title: "fix warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 ========== to ========== Use RateCounter for received bitrate stats: "WebRTC.Call.BitrateReceivedInKbps" "WebRTC.Call.VideoBitrateReceivedInKbps" "WebRTC.Call.AudioBitrateReceivedInKbps" "WebRTC.Call.RtcpBitrateReceivedInBps" Reports the average of periodically computed bitrates over a call (2 sec interval). Adds possibility to later modify the stats and use/report the periodic bitrates. BUG=webrtc:5283 Committed: https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc Cr-Commit-Position: refs/heads/master@{#14119} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/250fd97a6745022b406dd5d8fc3cf3805fd0eabc Cr-Commit-Position: refs/heads/master@{#14119} |