Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2303673005: MB: Enable rtc_use_h264 for GYP builds for now. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Enable rtc_use_h264 for GYP builds for now. NOTRY=True TBR=emhaldonado@webrtc.org Committed: https://crrev.com/84fcbd429f94d9049217bf4567934e937cf02ccd Cr-Commit-Position: refs/heads/master@{#14052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/build/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
I'm not sure why this was needed, this seems to work and we want to ...
4 years, 3 months ago (2016-09-02 18:51:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2303673005/1
4 years, 3 months ago (2016-09-02 18:52:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 18:55:42 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84fcbd429f94d9049217bf4567934e937cf02ccd Cr-Commit-Position: refs/heads/master@{#14052}
4 years, 3 months ago (2016-09-02 18:55:49 UTC) #9
hbos
4 years, 3 months ago (2016-09-05 07:58:45 UTC) #10
Message was sent while issue was closed.
On 2016/09/02 18:51:29, kjellander_webrtc wrote:
> I'm not sure why this was needed, this seems to work and we want to make sure
we
> support the H264 stuff for GYP if it's still possible.

I think we added the flag before we made it default to proprietary_codecs.

Powered by Google App Engine
This is Rietveld 408576698