Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2303283002: Introduce helpers to RtpSender to propagate RtpPacketToSend. (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Introduce helpers to RtpSender to propagate RtpPacketToSend. The helpers intended to replace and deprecate BuildRtpHeader when RtpSenderAudio/RtpSenderVideo will be updated to pass RtpPacket class instead of raw buffer for sending. BUG=webrtc:5261 R=sprang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/5e57b17283f78dbc0f72815746bdda6d9a92b8f2

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1 line) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 3 chunks +99 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
danilchap
Sample usage (and follow-up CL: https://codereview.webrtc.org/2292883002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc)
4 years, 3 months ago (2016-09-02 13:00:52 UTC) #2
sprang_webrtc
lgtm https://codereview.webrtc.org/2303283002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right): https://codereview.webrtc.org/2303283002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc#newcode465 webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:465: // Parse the padding packet and verify it's ...
4 years, 3 months ago (2016-09-02 13:56:44 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5e57b17283f78dbc0f72815746bdda6d9a92b8f2 Cr-Commit-Position: refs/heads/master@{#14051}
4 years, 3 months ago (2016-09-02 17:16:12 UTC) #5
danilchap
4 years, 3 months ago (2016-09-02 17:16:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5e57b17283f78dbc0f72815746bdda6d9a92b8f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698