Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: webrtc/video_send_stream.h

Issue 2303273002: Expose Ivf logging through the native API (Closed)
Patch Set: Nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video_receive_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video_send_stream.h
diff --git a/webrtc/video_send_stream.h b/webrtc/video_send_stream.h
index 2948d46874245962bf3488b2090952abc4f9f2d6..e987784c83bc8828c793dbf4805a48d37bd6b68e 100644
--- a/webrtc/video_send_stream.h
+++ b/webrtc/video_send_stream.h
@@ -13,8 +13,10 @@
#include <map>
#include <string>
+#include <utility>
#include <vector>
+#include "webrtc/base/platform_file.h"
#include "webrtc/common_types.h"
#include "webrtc/common_video/include/frame_callback.h"
#include "webrtc/config.h"
@@ -192,6 +194,22 @@ class VideoSendStream {
virtual Stats GetStats() = 0;
+ // Takes ownership of each file, is responsible for closing them later.
+ // Calling this method will close and finalize any current logs.
+ // Some codecs produce multiple streams (VP8 only at present), each of these
+ // streams will log to a separate file. kMaxSimulcastStreams in common_types.h
+ // gives the max number of such streams. If there is no file for a stream, or
+ // the file is rtc::kInvalidPlatformFileValue, frames from that stream will
+ // not be logged.
+ // If a frame to be written would make the log too large the write fails and
+ // the log is closed and finalized. A |byte_limit| of 0 means no limit.
+ virtual void EnableEncodedFrameRecording(
+ const std::vector<rtc::PlatformFile>& files,
+ size_t byte_limit) = 0;
+ inline void DisableEncodedFrameRecording() {
+ EnableEncodedFrameRecording(std::vector<rtc::PlatformFile>(), 0);
+ }
+
protected:
virtual ~VideoSendStream() {}
};
« no previous file with comments | « webrtc/video_receive_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698