Expose Ivf logging through the native API

webrtc/video/video_receive_stream.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 66 matching lines @@
   const Config& config() const { return config_; }
 
   void SetSyncChannel(VoiceEngine* voice_engine, int audio_channel_id);
 
   // Implements NackSender.
   void SendNack(const std::vector<uint16_t>& sequence_numbers) override;
 
   // Implements KeyFrameRequestSender.
   void RequestKeyFrame() override;
 
+  // Takes ownership of the file, is responsible for closing it later.
+  // Calling this method will close and finalize any current log.
+  // Giving rtc::kInvalidPlatformFileValue disables logging.
+  void SetLogFile(
+      rtc::PlatformFile file = rtc::kInvalidPlatformFileValue) override;

[sprang_webrtc, 2016/09/04 14:48:48]

I think this needs a more descriptive name.
Something like EnableEncodedFrameRecording() ?

+
  private:
   static bool DecodeThreadFunction(void* ptr);
   void Decode();
 
   TransportAdapter transport_adapter_;
   const VideoReceiveStream::Config config_;
   ProcessThread* const process_thread_;
   Clock* const clock_;
 
   rtc::PlatformThread decode_thread_;
 
   CongestionController* const congestion_controller_;
   CallStats* const call_stats_;
 
   vcm::VideoReceiver video_receiver_;
   std::unique_ptr<rtc::VideoSinkInterface<VideoFrame>> incoming_video_stream_;
   ReceiveStatisticsProxy stats_proxy_;
   RtpStreamReceiver rtp_stream_receiver_;
   std::unique_ptr<VideoStreamDecoder> video_stream_decoder_;
   RtpStreamsSynchronizer rtp_stream_sync_;
 
+  rtc::CriticalSection ivf_writer_crit_;

[sprang_webrtc, 2016/09/04 14:48:48]

I personally prefer lock as name, rather than crit, but up to you.

   std::unique_ptr<IvfFileWriter> ivf_writer_;

[sprang_webrtc, 2016/09/04 14:48:48]

add GUARDED_BY

 };
 }  // namespace internal
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_