Style changes in Audio Mixer

webrtc/modules/audio_mixer/audio_mixer_defines.cc

Index: webrtc/modules/audio_mixer/audio_mixer_defines.cc
diff --git a/webrtc/modules/audio_mixer/audio_mixer_defines.cc b/webrtc/modules/audio_mixer/audio_mixer_defines.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b5e0154f475750e1da379208389b96e158e3128b
--- /dev/null
+++ b/webrtc/modules/audio_mixer/audio_mixer_defines.cc
@@ -0,0 +1,38 @@
+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/audio_mixer/audio_mixer_defines.h"
+
+namespace webrtc {
+
+MixerAudioSource::MixerAudioSource() {}
+
+MixerAudioSource::~MixerAudioSource() {}
+
+bool MixerAudioSource::IsMixed() const {
+  return is_mixed_;
+}
+
+bool MixerAudioSource::WasMixed() const {

[ossu, 2016/10/03 12:49:01]

If WasMixed is the same as IsMixed, then why is there a WasMixed?
Or is this not part of this CL, but rather pulled in through a rebase? Still,
the question stands.

[aleloi, 2016/10/03 13:23:38]

There were two functions that did the same thing since the old mixer. It's for
abstraction and readability. IsMixed() is used after the mixing status is
updated in a certain iteration. WasMixed() is used before the update.

I noticed the comment is old. I've changed it to 'AudioMixerImpl'.

[ossu, 2016/10/04 09:00:05]

This doesn't make sense. IIUC, they will always return the same thing. Will this
change? Do they have different names only to sound right grammatically? Or is
this just how it's going to be for now, and this will change in a later CL?

[aleloi, 2016/10/04 09:15:18]

Yes, the functions will always return the same thing. There hasn't been any
plans to change it. Now that you pointed it out I also find it a bit confusing.

[ossu, 2016/10/04 09:28:44]

Since this is only a style related CL, I'm not going to press it further, but
something seems very strange if the exact same functionality needs two
different, but similar, names.

+  // Was mixed is the same as is mixed depending on perspective. This function
+  // is for the perspective of NewAudioConferenceMixerImpl.
+  return IsMixed();
+}
+
+int32_t MixerAudioSource::SetIsMixed(const bool mixed) {
+  is_mixed_ = mixed;
+  return 0;
+}
+
+void MixerAudioSource::ResetMixedStatus() {
+  is_mixed_ = false;
+}
+
+}  // namespace webrtc