Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: webrtc/modules/video_coding/frame_buffer2.cc

Issue 2302473002: FrameBuffer::NextFrame now return pair<frame, reason>. (Closed)
Patch Set: Return pair<reason, frame> instead of optional. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/frame_buffer2.cc
diff --git a/webrtc/modules/video_coding/frame_buffer2.cc b/webrtc/modules/video_coding/frame_buffer2.cc
index dab783254684e2ff140ed598bd3fdc022f9dbd57..e533e39834ada2387335658572c7d84901fd6b95 100644
--- a/webrtc/modules/video_coding/frame_buffer2.cc
+++ b/webrtc/modules/video_coding/frame_buffer2.cc
@@ -52,7 +52,8 @@ FrameBuffer::FrameBuffer(Clock* clock,
stopped_(false),
protection_mode_(kProtectionNack) {}
-std::unique_ptr<FrameObject> FrameBuffer::NextFrame(int64_t max_wait_time_ms) {
+std::pair<FrameBuffer::ReturnReason, std::unique_ptr<FrameObject>>
+FrameBuffer::NextFrame(int64_t max_wait_time_ms) {
int64_t latest_return_time = clock_->TimeInMilliseconds() + max_wait_time_ms;
int64_t now = clock_->TimeInMilliseconds();
int64_t wait_ms = max_wait_time_ms;
@@ -63,7 +64,7 @@ std::unique_ptr<FrameObject> FrameBuffer::NextFrame(int64_t max_wait_time_ms) {
rtc::CritScope lock(&crit_);
frame_inserted_event_.Reset();
if (stopped_)
- return std::unique_ptr<FrameObject>();
+ return std::make_pair(kStopped, nullptr);
now = clock_->TimeInMilliseconds();
wait_ms = max_wait_time_ms;
@@ -115,9 +116,9 @@ std::unique_ptr<FrameObject> FrameBuffer::NextFrame(int64_t max_wait_time_ms) {
decoded_frames_.insert(next_frame_it->first);
std::unique_ptr<FrameObject> frame = std::move(next_frame_it->second);
frames_.erase(frames_.begin(), ++next_frame_it);
- return frame;
+ return std::make_pair(kFrameFound, std::move(frame));
} else {
- return std::unique_ptr<FrameObject>();
+ return std::make_pair(kTimeout, nullptr);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698