GN: Introduce templates.

GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True

Committed: https://crrev.com/38a2132b02a76b8012e17ba61b7afa97268949c1
Cr-Commit-Position: refs/heads/master@{#14043}

[ehmaldonado_webrtc, 2016-09-01 14:51:35]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2016-09-01 14:51:36]

This is close to be ready, I think.

[ehmaldonado_webrtc, 2016-09-01 15:52:12]

On 2016/09/01 14:51:36, ehmaldonado_webrtc wrote:
> This is close to be ready, I think.

Changes I made:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "configs_suppressions += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

[kjellander_webrtc, 2016-09-01 19:48:13]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

BUG=
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "configs_suppressions += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
==========

[kjellander_webrtc, 2016-09-01 19:55:30]

Wohooo! This is awesome. 
I updated the CL description with the items you listed above, and a link to bug
6187.

Good that you started out like this, then we'll do more changes in next CL.

I fired a few Chromium trybots as well, to ensure we don't break
chromium.webrtc.fyi

https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni#n...
webrtc/build/webrtc.gni:165: configs_suppressions = []
I'm not fully happy with this name, as we're using "suppressions" for all the
memory tools etc to silence errors. What about just calling it 'remove_configs'
instead? Once we've started hunting down all the cases of
//build/config/clang:find_bad_constructs it's going to be rarely used anyway.

If you disagree I can probably be convinced to stick with 'configs_suppressions'
though...

[ehmaldonado_webrtc, 2016-09-02 07:44:29]

On 2016/09/01 19:55:30, kjellander_webrtc wrote:
> Wohooo! This is awesome. 
> I updated the CL description with the items you listed above, and a link to
bug
> 6187.
> 
> Good that you started out like this, then we'll do more changes in next CL.
> 
> I fired a few Chromium trybots as well, to ensure we don't break
> chromium.webrtc.fyi
> 
> https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni
> File webrtc/build/webrtc.gni (right):
> 
>
https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni#n...
> webrtc/build/webrtc.gni:165: configs_suppressions = []
> I'm not fully happy with this name, as we're using "suppressions" for all the
> memory tools etc to silence errors. What about just calling it
'remove_configs'
> instead? Once we've started hunting down all the cases of
> //build/config/clang:find_bad_constructs it's going to be rarely used anyway.
> 
> If you disagree I can probably be convinced to stick with
'configs_suppressions'
> though...

remove_configs sounds good.
I meant to write suppressed_configs, since it's already use in here
https://cs.chromium.org/chromium/src/third_party/webrtc/test/fuzzers/BUILD.gn...

[kjellander_webrtc, 2016-09-02 07:53:01]

On 2016/09/02 07:44:29, ehmaldonado_webrtc wrote:
> On 2016/09/01 19:55:30, kjellander_webrtc wrote:
> > Wohooo! This is awesome. 
> > I updated the CL description with the items you listed above, and a link to
> bug
> > 6187.
> > 
> > Good that you started out like this, then we'll do more changes in next CL.
> > 
> > I fired a few Chromium trybots as well, to ensure we don't break
> > chromium.webrtc.fyi
> > 
> > https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni
> > File webrtc/build/webrtc.gni (right):
> > 
> >
>
https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni#n...
> > webrtc/build/webrtc.gni:165: configs_suppressions = []
> > I'm not fully happy with this name, as we're using "suppressions" for all
the
> > memory tools etc to silence errors. What about just calling it
> 'remove_configs'
> > instead? Once we've started hunting down all the cases of
> > //build/config/clang:find_bad_constructs it's going to be rarely used
anyway.
> > 
> > If you disagree I can probably be convinced to stick with
> 'configs_suppressions'
> > though...
> 
> remove_configs sounds good.
> I meant to write suppressed_configs, since it's already use in here
>
https://cs.chromium.org/chromium/src/third_party/webrtc/test/fuzzers/BUILD.gn...

OK, if it's already used somewhere else, let's go with that name then:
"suppressed_configs".

[kjellander_webrtc, 2016-09-02 07:53:51]

On 2016/09/02 07:53:01, kjellander_webrtc wrote:
> On 2016/09/02 07:44:29, ehmaldonado_webrtc wrote:
> > On 2016/09/01 19:55:30, kjellander_webrtc wrote:
> > > Wohooo! This is awesome. 
> > > I updated the CL description with the items you listed above, and a link
to
> > bug
> > > 6187.
> > > 
> > > Good that you started out like this, then we'll do more changes in next
CL.
> > > 
> > > I fired a few Chromium trybots as well, to ensure we don't break
> > > chromium.webrtc.fyi
> > > 
> > >
https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni
> > > File webrtc/build/webrtc.gni (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/2301053002/diff/40001/webrtc/build/webrtc.gni#n...
> > > webrtc/build/webrtc.gni:165: configs_suppressions = []
> > > I'm not fully happy with this name, as we're using "suppressions" for all
> the
> > > memory tools etc to silence errors. What about just calling it
> > 'remove_configs'
> > > instead? Once we've started hunting down all the cases of
> > > //build/config/clang:find_bad_constructs it's going to be rarely used
> anyway.
> > > 
> > > If you disagree I can probably be convinced to stick with
> > 'configs_suppressions'
> > > though...
> > 
> > remove_configs sounds good.
> > I meant to write suppressed_configs, since it's already use in here
> >
>
https://cs.chromium.org/chromium/src/third_party/webrtc/test/fuzzers/BUILD.gn...
> 
> OK, if it's already used somewhere else, let's go with that name then:
> "suppressed_configs".

lgtm to unblock you since I'll be out in 1-2 hours now.

[ehmaldonado_webrtc, 2016-09-02 07:57:49]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "configs_suppressions += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
==========

[ehmaldonado_webrtc, 2016-09-02 08:05:59]

Patchset #5 (id:80001) has been deleted

[ehmaldonado_webrtc, 2016-09-02 08:08:09]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 08:08:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2301053002/#ps100001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-09-02 08:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ehmaldonado_webrtc, 2016-09-02 09:13:41]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
==========

[ehmaldonado_webrtc, 2016-09-02 09:41:52]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-02 09:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:45:33]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[ehmaldonado_webrtc, 2016-09-02 09:46:05]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-09-02 09:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 10:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 10:12:50]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7998)

[ehmaldonado_webrtc, 2016-09-02 11:01:55]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 11:01:55]

The CQ bit was unchecked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 11:01:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2301053002/#ps120001 (title:
"Rebase")

[ehmaldonado_webrtc, 2016-09-02 11:01:56]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-09-02 11:02:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 11:10:39]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-02 11:10:40]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-02 11:10:46]

Description was changed from

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True
==========

to

==========
GN: Introduce templates.

Defines the rtc_executable, rtc_source_set, rtc_test and
rtc_static_library templates.

These templates provide no functionality yet, but will enable common
configuration to be introduced, avoiding repetition in every target

Changes summary:
- Prepend rtc_ to test, source_set, executable and static_library targets
- Change "configs -= [" to "suppressed_configs += ["
- Include webrtc/build/webrtc.gni where it wasn't included yet
- Delete import("//testing/test.gni"), since rtc_test makes it unnecessary.

BUG=webrtc:6187
TBR=henrik.lundin@webrtc.org,tommi@webrtc.org
NOTRY=True

Committed: https://crrev.com/38a2132b02a76b8012e17ba61b7afa97268949c1
Cr-Commit-Position: refs/heads/master@{#14043}
==========

[commit-bot: I haz the power, 2016-09-02 11:10:48]

Patchset 6 (id:??) landed as
https://crrev.com/38a2132b02a76b8012e17ba61b7afa97268949c1
Cr-Commit-Position: refs/heads/master@{#14043}