Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2300953002: Delete cricket::VideoFrame::GetCopyWithRotationApplied. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete cricket::VideoFrame::GetCopyWithRotationApplied. There are no known uses. Use in Chrome was eliminated in cl https://codereview.chromium.org/2293253003/ BUG=webrtc:5682 Committed: https://crrev.com/c6b9da44c3f9c3bc48fad36252ce26d196bc7071 Cr-Commit-Position: refs/heads/master@{#14049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nisse-webrtc
PTAL. I'd expect gyp bots for mac and/or ios to fail, because of talk/. But ...
4 years, 3 months ago (2016-09-01 09:48:54 UTC) #4
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-01 10:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300953002/1
4 years, 3 months ago (2016-09-02 11:24:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_dbg on ...
4 years, 3 months ago (2016-09-02 13:24:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300953002/1
4 years, 3 months ago (2016-09-02 14:34:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 15:26:00 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 15:26:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6b9da44c3f9c3bc48fad36252ce26d196bc7071
Cr-Commit-Position: refs/heads/master@{#14049}

Powered by Google App Engine
This is Rietveld 408576698