Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2300643002: Emit landmine for Android builds to solve compile lint errors (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, ossu, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Emit landmine for Android builds to solve compile lint errors The recent roll in https://codereview.webrtc.org/2293863002/ seems to cause build errors on some Android bots. Clobbering all of them should solve it. TBR=ehmaldonado@webrtc.org NOTRY=True Committed: https://crrev.com/08352ab8c51b26bc7ac2d9e0a130c9589793e6c6 Cr-Commit-Position: refs/heads/master@{#14000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/build/get_landmines.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
4 years, 3 months ago (2016-08-31 15:05:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300643002/1
4 years, 3 months ago (2016-08-31 15:06:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 15:24:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08352ab8c51b26bc7ac2d9e0a130c9589793e6c6 Cr-Commit-Position: refs/heads/master@{#14000}
4 years, 3 months ago (2016-08-31 15:24:15 UTC) #8
kjellander_webrtc
4 years, 3 months ago (2016-08-31 15:56:14 UTC) #9
Message was sent while issue was closed.
On 2016/08/31 15:24:15, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/08352ab8c51b26bc7ac2d9e0a130c9589793e6c6
> Cr-Commit-Position: refs/heads/master@{#14000}

Confirmed landmine "exploding" (clobbering) as intended:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder%20x86...

Powered by Google App Engine
This is Rietveld 408576698