GN Templates: Move common_config to the template.

webrtc/modules/video_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 
@@ skipping 56 matching lines @@
     "timestamp_map.cc",
     "timestamp_map.h",
     "timing.cc",
     "timing.h",
     "video_coding_impl.cc",
     "video_coding_impl.h",
     "video_receiver.cc",
     "video_sender.cc",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
@@ skipping 20 matching lines @@
     "utility/ivf_file_writer.h",
     "utility/moving_average.h",
     "utility/qp_parser.cc",
     "utility/qp_parser.h",
     "utility/quality_scaler.cc",
     "utility/quality_scaler.h",
     "utility/vp8_header_parser.cc",
     "utility/vp8_header_parser.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "../../common_video",
     "../../system_wrappers",
   ]
 }
 
 rtc_source_set("webrtc_h264") {
   sources = [
     "codecs/h264/h264.cc",
     "codecs/h264/include/h264.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   defines = []
   deps = [
@@ skipping 33 matching lines @@
       "codecs/h264/h264_video_toolbox_encoder.mm",
       "codecs/h264/h264_video_toolbox_nalu.cc",
       "codecs/h264/h264_video_toolbox_nalu.h",
     ]
 
     configs += [
       "../..:common_objc",
       "//build/config/compiler:enable_arc",
     ]
 
+    suppressed_configs += [ rtc_common_config ]

[kjellander_webrtc, 2016/09/05 06:50:28]

Is this needed? Since it's not a part of examples/tests I would assume the GYP
version already had the common_config in the GYP build, so it really should pass
compilation.

Otherwise: add a TODO+bug for cleanup (and assign the bug to hbos@).

+
     deps = [
       "../../sdk:rtc_sdk_common_objc",
     ]
 
     libs = [
       "CoreFoundation.framework",
       "CoreMedia.framework",
       "CoreVideo.framework",
       "VideoToolbox.framework",
     ]
@@ skipping 15 matching lines @@
     }
   }
 }
 
 rtc_source_set("webrtc_i420") {
   sources = [
     "codecs/i420/i420.cc",
     "codecs/i420/include/i420.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "../../system_wrappers",
@@ skipping 11 matching lines @@
     "codecs/vp8/reference_picture_selection.h",
     "codecs/vp8/screenshare_layers.cc",
     "codecs/vp8/screenshare_layers.h",
     "codecs/vp8/simulcast_encoder_adapter.cc",
     "codecs/vp8/simulcast_encoder_adapter.h",
     "codecs/vp8/temporal_layers.h",
     "codecs/vp8/vp8_impl.cc",
     "codecs/vp8/vp8_impl.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
@@ skipping 13 matching lines @@
   sources = [
     "codecs/vp9/include/vp9.h",
     "codecs/vp9/screenshare_layers.cc",
     "codecs/vp9/screenshare_layers.h",
     "codecs/vp9/vp9_frame_buffer_pool.cc",
     "codecs/vp9/vp9_frame_buffer_pool.h",
     "codecs/vp9/vp9_impl.cc",
     "codecs/vp9/vp9_impl.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":video_coding_utility",
@@ skipping 13 matching lines @@
       "codecs/test/packet_manipulator.cc",
       "codecs/test/packet_manipulator.h",
       "codecs/test/predictive_packet_manipulator.cc",
       "codecs/test/predictive_packet_manipulator.h",
       "codecs/test/stats.cc",
       "codecs/test/stats.h",
       "codecs/test/videoprocessor.cc",
       "codecs/test/videoprocessor.h",
     ]
 
-    configs += [ "../..:common_config" ]
     public_configs = [ "../..:common_inherited_config" ]
 
     if (is_clang) {
       # Suppress warnings from Chrome's Clang plugins.
       # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       "../../test:test_support",
     ]
   }
 }