GN Templates: Move common_config to the template.

webrtc/examples/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 if (is_android) {
@@ skipping 122 matching lines @@
   config("apprtc_common_config") {
     include_dirs = [ "objc/AppRTCDemo/common" ]
   }
 
   rtc_source_set("apprtc_common") {
     sources = [
       "objc/AppRTCDemo/common/ARDUtilities.h",
       "objc/AppRTCDemo/common/ARDUtilities.m",
     ]
     configs += [
-      "..:common_config",
       ":warnings_config",
       "//build/config/compiler:enable_arc",
     ]
     public_configs = [
       "..:common_inherited_config",
       ":apprtc_common_config",
     ]
 
     deps = [
       "../sdk:rtc_sdk_common_objc",
@@ skipping 48 matching lines @@
       "objc/AppRTCDemo/RTCIceCandidate+JSON.h",
       "objc/AppRTCDemo/RTCIceCandidate+JSON.m",
       "objc/AppRTCDemo/RTCIceServer+JSON.h",
       "objc/AppRTCDemo/RTCIceServer+JSON.m",
       "objc/AppRTCDemo/RTCMediaConstraints+JSON.h",
       "objc/AppRTCDemo/RTCMediaConstraints+JSON.m",
       "objc/AppRTCDemo/RTCSessionDescription+JSON.h",
       "objc/AppRTCDemo/RTCSessionDescription+JSON.m",
     ]
     configs += [
-      "..:common_config",
       "//build/config/compiler:enable_arc",
       ":warnings_config",
     ]
     public_configs = [
       "..:common_inherited_config",
       ":apprtc_signaling_config",
     ]
     deps = [
       ":apprtc_common",
       ":socketrocket",
@@ skipping 69 matching lines @@
 
   if (is_mac) {
     rtc_source_set("AppRTCDemo_app") {
       sources = [
         "objc/AppRTCDemo/mac/APPRTCAppDelegate.h",
         "objc/AppRTCDemo/mac/APPRTCAppDelegate.m",
         "objc/AppRTCDemo/mac/APPRTCViewController.h",
         "objc/AppRTCDemo/mac/APPRTCViewController.m",
       ]
       configs += [
-        "..:common_config",
         "..:common_objc",
         "//build/config/compiler:enable_arc",
       ]
       deps = [
         ":apprtc_common",
         ":apprtc_signaling",
       ]
     }
 
     mac_app_bundle("AppRTCDemo") {
@@ skipping 40 matching lines @@
       cflags += [ "-Wno-partial-availability" ]
     }
   }
 
   rtc_source_set("socketrocket") {
     sources = [
       "objc/AppRTCDemo/third_party/SocketRocket/SRWebSocket.h",
       "objc/AppRTCDemo/third_party/SocketRocket/SRWebSocket.m",
     ]
     configs += [
-      "..:common_config",
       "//build/config/compiler:enable_arc",
       ":socketrocket_warning_config",
     ]
     public_configs = [
       "..:common_inherited_config",
       ":socketrocket_include_config",
     ]
 
     libs = [
       "CFNetwork.framework",
@@ skipping 32 matching lines @@
 
   rtc_executable("peerconnection_client") {
     sources = [
       "peerconnection/client/conductor.cc",
       "peerconnection/client/conductor.h",
       "peerconnection/client/defaults.cc",
       "peerconnection/client/defaults.h",
       "peerconnection/client/peer_connection_client.cc",
       "peerconnection/client/peer_connection_client.h",
     ]
+    suppressed_configs += [ rtc_common_config ]

[kjellander_webrtc, 2016/09/05 06:50:28]

Add a TODO(ehmaldonado) here, preferably pointing to a tracking bug as well
(file a new bug for getting the examples to compile with our standard set of
warnings).

     if (is_clang) {
       # Suppress warnings from the Chromium Clang plugin.
       # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
     if (is_win) {
       sources += [
         "peerconnection/client/flagdefs.h",
         "peerconnection/client/main.cc",
         "peerconnection/client/main_wnd.cc",
@@ skipping 90 matching lines @@
       "//webrtc/system_wrappers:field_trial_default",
       "//webrtc/system_wrappers:metrics_default",
     ]
     if (is_clang) {
       # Suppress warnings from the Chromium Clang plugin.
       # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }