Chromium Code Reviews

Issue 2299983002: Revert of Initial version of new file wrapper (Closed)

Created:
4 years, 3 months ago by palmkvist
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Initial version of new file wrapper (patchset #26 id:490001 of https://codereview.webrtc.org/2214763002/ ) Reason for revert: Breaks things upstream Original issue's description: > Initial version of new file wrapper > > BUG=webrt:6177 > R=mflodman@webrtc.org, sprang@webrtc.org > > Committed: https://crrev.com/d714d19d224b356ab2f14ed7ba6e872a4df6c84f > Cr-Commit-Position: refs/heads/master@{#14016} TBR=mflodman@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrt:6177 Committed: https://crrev.com/e8a6697a5e45a925af407e31ad81e5c362ee7fd4 Cr-Commit-Position: refs/heads/master@{#14017}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -509 lines)
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments
M webrtc/base/base.gyp View 2 chunks +0 lines, -12 lines 0 comments
D webrtc/base/file.h View 1 chunk +0 lines, -67 lines 0 comments
D webrtc/base/file.cc View 1 chunk +0 lines, -36 lines 0 comments
D webrtc/base/file_posix.cc View 1 chunk +0 lines, -96 lines 0 comments
D webrtc/base/file_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments
D webrtc/base/file_win.cc View 1 chunk +0 lines, -120 lines 0 comments
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -1 line 0 comments

Messages

Total messages: 6 (2 generated)
palmkvist
Created Revert of Initial version of new file wrapper
4 years, 3 months ago (2016-09-01 11:15:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2299983002/1
4 years, 3 months ago (2016-09-01 11:15:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 11:15:40 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 11:15:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8a6697a5e45a925af407e31ad81e5c362ee7fd4
Cr-Commit-Position: refs/heads/master@{#14017}

Powered by Google App Engine