RTCStatsCollector: timestamps updated.

webrtc/stats/rtcstatscollector_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/stats/rtcstatscollector.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "webrtc/api/jsepsessiondescription.h"
 #include "webrtc/api/rtcstats_objects.h"
 #include "webrtc/api/rtcstatsreport.h"
 #include "webrtc/api/test/mock_datachannel.h"
 #include "webrtc/api/test/mock_peerconnection.h"
 #include "webrtc/api/test/mock_webrtcsession.h"
 #include "webrtc/base/checks.h"
+#include "webrtc/base/fakeclock.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/logging.h"
-#include "webrtc/base/test/faketiming.h"
+#include "webrtc/base/timedelta.h"
+#include "webrtc/base/timeutils.h"
+#include "webrtc/base/timing.h"
 #include "webrtc/media/base/fakemediaengine.h"
 
 using testing::Return;
 using testing::ReturnRef;
 
 namespace webrtc {
 
 class RTCStatsCollectorTester : public SetSessionDescriptionObserver {
  public:
   RTCStatsCollectorTester()
@@ skipping 34 matching lines @@
   MockWebRtcSession session_;
   MockPeerConnection pc_;
 
   std::vector<rtc::scoped_refptr<DataChannel>> data_channels_;
 };
 
 class RTCStatsCollectorTest : public testing::Test {
  public:
   RTCStatsCollectorTest()
     : test_(new rtc::RefCountedObject<RTCStatsCollectorTester>()),
-      timing_(new rtc::FakeTiming()),
-      collector_(&test_->pc(), 0.05, std::unique_ptr<rtc::Timing>(timing_)) {
+      collector_(&test_->pc(), 50 * rtc::kNumMicrosecsPerMillisec) {
   }
 
  protected:
   rtc::scoped_refptr<RTCStatsCollectorTester> test_;
-  rtc::FakeTiming* timing_;  // Owned by |collector_|.
   RTCStatsCollector collector_;
 };
 
 TEST_F(RTCStatsCollectorTest, CachedStatsReport) {
+  rtc::ScopedFakeClock fake_clock;
   // Caching should ensure |a| and |b| are the same report.
   rtc::scoped_refptr<const RTCStatsReport> a = collector_.GetStatsReport();
   rtc::scoped_refptr<const RTCStatsReport> b = collector_.GetStatsReport();
   EXPECT_TRUE(a);
   EXPECT_EQ(a.get(), b.get());
   // Invalidate cache by clearing it.
   collector_.ClearCachedStatsReport();
   rtc::scoped_refptr<const RTCStatsReport> c = collector_.GetStatsReport();
   EXPECT_TRUE(c);
   EXPECT_NE(b.get(), c.get());
   // Invalidate cache by advancing time.
-  timing_->AdvanceTimeMillisecs(51.0);
+  fake_clock.AdvanceTime(rtc::TimeDelta::FromMilliseconds(51));
   rtc::scoped_refptr<const RTCStatsReport> d = collector_.GetStatsReport();
   EXPECT_TRUE(d);
   EXPECT_NE(c.get(), d.get());
 }
 
 TEST_F(RTCStatsCollectorTest, CollectRTCPeerConnectionStats) {
+  int64_t before = static_cast<int64_t>(
+      rtc::Timing::WallTimeNow() * rtc::kNumMicrosecsPerSec);
   rtc::scoped_refptr<const RTCStatsReport> report = collector_.GetStatsReport();
+  int64_t after = static_cast<int64_t>(
+      rtc::Timing::WallTimeNow() * rtc::kNumMicrosecsPerSec);
   EXPECT_EQ(report->GetStatsOfType<RTCPeerConnectionStats>().size(),
             static_cast<size_t>(1)) << "Expecting 1 RTCPeerConnectionStats.";
   const RTCStats* stats = report->Get("RTCPeerConnection");
   EXPECT_TRUE(stats);
-  EXPECT_EQ(stats->timestamp(), timing_->TimerNow());
+  EXPECT_LE(before, stats->timestamp_us());
+  EXPECT_LE(stats->timestamp_us(), after);
   {
     // Expected stats with no data channels
     const RTCPeerConnectionStats& pcstats =
         stats->cast_to<RTCPeerConnectionStats>();
     EXPECT_EQ(*pcstats.data_channels_opened, static_cast<uint32_t>(0));
     EXPECT_EQ(*pcstats.data_channels_closed, static_cast<uint32_t>(0));
   }
 
   test_->data_channels().push_back(
       new MockDataChannel(DataChannelInterface::kConnecting));
@@ skipping 17 matching lines @@
     // open/closed, we would expect opened >= closed and (opened - closed) to be
     // the number currently open. crbug.com/636818.
     const RTCPeerConnectionStats& pcstats =
         stats->cast_to<RTCPeerConnectionStats>();
     EXPECT_EQ(*pcstats.data_channels_opened, static_cast<uint32_t>(1));
     EXPECT_EQ(*pcstats.data_channels_closed, static_cast<uint32_t>(3));
   }
 }
 
 }  // namespace webrtc