RTCStatsCollector: timestamps updated.

RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True

Committed: https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131
Cr-Commit-Position: refs/heads/master@{#13997}

[hbos, 2016-08-31 12:06:35]

hbos@webrtc.org changed reviewers:
+ nisse@webrtc.org

[hbos, 2016-08-31 12:06:36]

Please take a look, nisse.

[hbos, 2016-08-31 12:06:44]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 12:06:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 12:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 12:07:41]

Dry run: Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[nisse-webrtc, 2016-08-31 12:41:36]

On 2016/08/31 12:06:36, hbos wrote:
> Please take a look, nisse.

lgtm.

I think it's unusual in webrtc to represent times using floating point and units
of seconds. Please consider switching to integers in microsecs or millisecs,
e.g., 

  int64_t cache_timestamp_us;
  int64_t utc_timestamp_us;

If this is old code, I don't insist, you can leave the doubles if you believe
that makes things easier.

[hbos, 2016-08-31 13:32:59]

Patchset #2 (id:20001) has been deleted

[hbos, 2016-08-31 13:33:58]

On 2016/08/31 12:41:36, nisse-webrtc wrote:
> On 2016/08/31 12:06:36, hbos wrote:
> > Please take a look, nisse.
> 
> lgtm.
> 
> I think it's unusual in webrtc to represent times using floating point and
units
> of seconds. Please consider switching to integers in microsecs or millisecs,
> e.g., 
> 
>   int64_t cache_timestamp_us;
>   int64_t utc_timestamp_us;
> 
> If this is old code, I don't insist, you can leave the doubles if you believe
> that makes things easier.

I changed it to microseconds, also changing it for RTCStats and related
unittests.

[hbos, 2016-08-31 13:34:13]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-08-31 13:34:14]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2299643002/#ps40001 (title:
"Changed RTCStatsCollector and RTCStats to use uint64_t microseconds time,
affecting unittests")

[commit-bot: I haz the power, 2016-08-31 13:34:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 13:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 13:35:31]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[nisse-webrtc, 2016-08-31 14:04:39]

On 2016/08/31 13:33:58, hbos wrote:
> On 2016/08/31 12:41:36, nisse-webrtc wrote:
> > On 2016/08/31 12:06:36, hbos wrote:
> > > Please take a look, nisse.
> > 
> > lgtm.
> > 
> > I think it's unusual in webrtc to represent times using floating point and
> units
> > of seconds. Please consider switching to integers in microsecs or millisecs,
> > e.g., 
> > 
> >   int64_t cache_timestamp_us;
> >   int64_t utc_timestamp_us;
> > 
> > If this is old code, I don't insist, you can leave the doubles if you
believe
> > that makes things easier.
> 
> I changed it to microseconds, also changing it for RTCStats and related
> unittests.

Nice. One nit: I think the main convention in webrtc is to used signed variables
for times, i.e., int64_t, not uint64_t. Unclear why, but consider changing it.

[hbos, 2016-08-31 14:20:38]

On 2016/08/31 14:04:39, nisse-webrtc wrote:
> Nice. One nit: I think the main convention in webrtc is to used signed
variables
> for times, i.e., int64_t, not uint64_t. Unclear why, but consider changing it.

Done.

[hbos, 2016-08-31 14:21:13]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-08-31 14:21:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2299643002/#ps60001 (title:
"uint64_t -> int64_t timestamps")

[commit-bot: I haz the power, 2016-08-31 14:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 14:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 14:22:31]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[hbos, 2016-08-31 14:52:58]

Description was changed from

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
==========

to

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True
==========

[hbos, 2016-08-31 14:53:10]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-08-31 14:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 14:57:39]

Description was changed from

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True
==========

to

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-31 14:57:41]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-31 14:57:52]

Description was changed from

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True
==========

to

==========
RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True

Committed: https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131
Cr-Commit-Position: refs/heads/master@{#13997}
==========

[commit-bot: I haz the power, 2016-08-31 14:57:53]

Patchset 3 (id:??) landed as
https://crrev.com/0e6758d7efc64a93d27f45b278d867d7f13f2131
Cr-Commit-Position: refs/heads/master@{#13997}