Remove all reference to carbon api

Remove all reference to carbon api

BUG=webrtc:6282
Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
Cr-Commit-Position: refs/heads/master@{#14080}

[kthelgason, 2016-08-31 11:06:58]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org, mflodman@webrtc.org

[kthelgason, 2016-08-31 11:07:07]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 11:07:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-08-31 11:07:28]

Description was changed from

==========
Remove all reference to carbon api

BUG=6282
==========

to

==========
Remove all reference to carbon api

BUG=webrtc:6282
==========

[commit-bot: I haz the power, 2016-08-31 11:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 11:08:30]

Dry run: Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[kthelgason, 2016-08-31 13:27:06]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 13:27:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 13:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 13:28:01]

Dry run: Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[kthelgason, 2016-09-01 09:10:02]

Can I get some LGTMs on this?

[magjed_webrtc, 2016-09-01 10:18:34]

This lgtm, but I'm not familiar with carbon and what the purpose of it used to
be.

https://codereview.webrtc.org/2299633002/diff/1/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/2299633002/diff/1/webrtc/base/base.gyp#newcode266
webrtc/base/base.gyp:266: 'applefilesystem.mm',
nit: This should be put in alphabetical order.

[mflodman, 2016-09-02 08:56:13]

I really only know about the rendering parts, but LGTM if this isn't used
anywhere (with Magnus' comment addressed).

[kthelgason, 2016-09-05 19:11:56]

On 2016/09/02 08:56:13, mflodman wrote:
> I really only know about the rendering parts, but LGTM if this isn't used
> anywhere (with Magnus' comment addressed).

As far as I know, this code is only relevant for 32-bit macs, which haven't been
around for a long time.
Even if someone cares about using WebRTC on 32-bit macs, they should still move
off these APIs regardless.

It's possible that someone is using this stuff, and I guess if anyone makes
noise we can just revert this :)

[kthelgason, 2016-09-06 06:50:51]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-09-06 06:50:52]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2299633002/#ps20001 (title:
"Remove all reference to carbon api")

[commit-bot: I haz the power, 2016-09-06 06:50:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-06 07:38:20]

Description was changed from

==========
Remove all reference to carbon api

BUG=webrtc:6282
==========

to

==========
Remove all reference to carbon api

BUG=webrtc:6282
==========

[commit-bot: I haz the power, 2016-09-06 07:38:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 07:38:28]

Description was changed from

==========
Remove all reference to carbon api

BUG=webrtc:6282
==========

to

==========
Remove all reference to carbon api

BUG=webrtc:6282

Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
Cr-Commit-Position: refs/heads/master@{#14080}
==========

[commit-bot: I haz the power, 2016-09-06 07:38:29]

Patchset 2 (id:??) landed as
https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
Cr-Commit-Position: refs/heads/master@{#14080}

[kthelgason, 2016-09-06 07:43:39]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2316563002/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks chromium build.

[kthelgason, 2016-09-07 08:12:16]

Description was changed from

==========
Remove all reference to carbon api

BUG=webrtc:6282

Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
Cr-Commit-Position: refs/heads/master@{#14080}
==========

to

==========
Remove all reference to carbon api

BUG=webrtc:6282

Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
Cr-Commit-Position: refs/heads/master@{#14080}
==========

[kthelgason, 2016-09-07 08:12:27]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-09-07 08:12:28]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2299633002/#ps40001 (title:
"Fix chromium build errors")

[commit-bot: I haz the power, 2016-09-07 08:12:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 08:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 08:23:01]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16417)

[kthelgason, 2016-09-07 08:31:05]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2016-09-07 08:31:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 10:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 10:13:12]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[magjed_webrtc, 2016-09-07 11:20:34]

If you want to reland this, the best way is to press the Revert button on the
revert CL.

[kthelgason, 2016-09-07 11:22:20]

On 2016/09/07 11:20:34, magjed_webrtc wrote:
> If you want to reland this, the best way is to press the Revert button on the
> revert CL.

There are new changes added that were not in the original CL

[magjed_webrtc, 2016-09-07 11:58:45]

On 2016/09/07 11:22:20, kthelgason wrote:
> On 2016/09/07 11:20:34, magjed_webrtc wrote:
> > If you want to reland this, the best way is to press the Revert button on
the
> > revert CL.
> 
> There are new changes added that were not in the original CL

Yeah, so the process in these cases are:
 - Press Revert button on the revert CL.
 - Uncheck 'Automatically send Revert CL to CQ:'
 - Change the title of Patch Set 1 to 'Original CL'
 - Upload new changes with some appropriate patch set title.
 - Send out for review if new changes are non-trivial.
 - Land.