Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2299023004: Remove unused agc_unittest.cc and agc_harness.cc (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Remove unused unit test webrtc/modules/audio_processing/agc/agc_unittest.cc - Remove webrtc/tools/agc/test_utils.cc/.h - only used from the above test. - Remove webrtc/tools/agc/agc_harness.cc - not used anymore. BUG=webrtc:4690 Committed: https://crrev.com/f383c5754f4aef35830484d71517a84742c4166f Cr-Commit-Position: refs/heads/master@{#14039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -606 lines) Patch
M webrtc/modules/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D webrtc/modules/audio_processing/agc/agc_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +0 lines, -38 lines 0 comments Download
D webrtc/tools/agc/agc_harness.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D webrtc/tools/agc/test_utils.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/tools/agc/test_utils.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
the sun
4 years, 3 months ago (2016-09-01 12:29:22 UTC) #2
hlundin-webrtc
On 2016/09/01 12:29:22, the sun wrote: Typo in CL title and first line of description. ...
4 years, 3 months ago (2016-09-01 13:05:24 UTC) #4
hlundin-webrtc
lgtm (with title and descriptions fixed) Good riddance!
4 years, 3 months ago (2016-09-01 13:06:46 UTC) #5
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-09-02 07:48:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2299023004/1
4 years, 3 months ago (2016-09-02 07:51:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 09:39:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:39:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f383c5754f4aef35830484d71517a84742c4166f
Cr-Commit-Position: refs/heads/master@{#14039}

Powered by Google App Engine
This is Rietveld 408576698