Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2297663004: Use AggressiveConfiguration as the default configuration in IOS (Closed)
Patch Set: Add argument to the RTCConfiguration constructor Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 624c67f9cba562bbc111fb79fe80ca2d6eafe31c..24e1207050ede27d3f33382debf1e56a9acf4883 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -247,9 +247,14 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// An aggressive configuration that has better performance, although it
// may be riskier and may need extra support in the application.
static RTCConfiguration AggressiveConfiguration() {
- RTCConfiguration config;
- config.redetermine_role_on_ice_restart = false;
- return config;
+ return RTCConfiguration(true);
+ }
+
+ RTCConfiguration() = default;
+ RTCConfiguration(bool aggressive) {
+ if (aggressive) {
+ redetermine_role_on_ice_restart = false;
+ }
pthatcher1 2016/09/01 07:05:44 I can understand why you would want to have a cons
honghaiz3 2016/09/01 16:07:50 Done.
}
bool dscp() { return media_config.enable_dscp; }
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698