Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2297533002: Reorder member functions in RtpFecTest. (pt. 4b) (Closed)

Created:
4 years, 3 months ago by brandtr
Modified:
4 years, 3 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reorder member functions in RtpFecTest. Place member functions before tests. No changes to the functionality. BUG=webrtc:5654 R=danilchap@webrtc.org Committed: https://crrev.com/ea7beb9741da38043432aefb695731c49ff7c413 Cr-Commit-Position: refs/heads/master@{#14322}

Patch Set 1 : Move around methods in RtpFecUnittest. #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase. #

Patch Set 8 : Rebase. #

Patch Set 9 : Rebase. #

Patch Set 10 : Rebase. #

Patch Set 11 : Rebase. #

Patch Set 12 : Rebase. #

Patch Set 13 : Rebase after gyp deprecation. #

Patch Set 14 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -88 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_fec_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +88 lines, -88 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (12 generated)
brandtr
Rebase.
4 years, 3 months ago (2016-08-30 09:19:08 UTC) #2
brandtr
This is just a cleanup CL, where some member functions have been moved around. I ...
4 years, 3 months ago (2016-08-30 09:23:47 UTC) #4
danilchap
On 2016/08/30 09:23:47, brandtr wrote: > This is just a cleanup CL, where some member ...
4 years, 3 months ago (2016-08-30 12:45:17 UTC) #5
brandtr
Rebase.
4 years, 3 months ago (2016-08-30 14:28:10 UTC) #6
brandtr
Rebase.
4 years, 3 months ago (2016-09-01 10:12:02 UTC) #8
brandtr
Rebase.
4 years, 3 months ago (2016-09-02 07:24:36 UTC) #9
brandtr
Rebase.
4 years, 3 months ago (2016-09-02 08:27:02 UTC) #10
brandtr
Rebase.
4 years, 3 months ago (2016-09-02 11:07:37 UTC) #11
brandtr
Rebase.
4 years, 3 months ago (2016-09-06 14:35:50 UTC) #12
brandtr
Rebase.
4 years, 3 months ago (2016-09-13 11:38:40 UTC) #13
brandtr
Rebase.
4 years, 3 months ago (2016-09-13 11:43:35 UTC) #14
brandtr
Rebase.
4 years, 3 months ago (2016-09-14 11:37:33 UTC) #15
brandtr
Rebase.
4 years, 3 months ago (2016-09-20 08:51:08 UTC) #16
brandtr
Rebase after gyp deprecation.
4 years, 3 months ago (2016-09-20 09:31:13 UTC) #17
brandtr
Rebase.
4 years, 3 months ago (2016-09-20 11:07:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2297533002/280001
4 years, 3 months ago (2016-09-21 09:19:09 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16940)
4 years, 3 months ago (2016-09-21 09:48:33 UTC) #27
brandtr
4 years, 3 months ago (2016-09-21 10:01:35 UTC) #29
Message was sent while issue was closed.
Committed patchset #14 (id:280001) manually as
ea7beb9741da38043432aefb695731c49ff7c413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698