Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by skvlad Modified:
4 years, 3 months ago Reviewers:
mflodman CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEventLogParser: use std::vector to reduce stack usage
ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array
for a temporary buffer. This was causing problems in build environments
with restrictions on stack size.
This change replaces it with an std::vector.
NOTRY=true
Committed: https://crrev.com/1afdf99f9c00155b0c250e9a358de0184933b27c
Cr-Commit-Position: refs/heads/master@{#14055}
Patch Set 1 #
Created: 4 years, 3 months ago
Messages
Total messages: 15 (8 generated)
Description was changed from ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. ========== to ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. ==========
skvlad@webrtc.org changed reviewers: + mflodman@webrtc.org
lgtm
The CQ bit was checked by skvlad@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. ========== to ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. NOTRY=true ==========
The CQ bit was checked by skvlad@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. NOTRY=true ========== to ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. NOTRY=true ========== to ========== EventLogParser: use std::vector to reduce stack usage ParsedRtcEventLog::ParseStream was using a stack-allocated 64kb array for a temporary buffer. This was causing problems in build environments with restrictions on stack size. This change replaces it with an std::vector. NOTRY=true Committed: https://crrev.com/1afdf99f9c00155b0c250e9a358de0184933b27c Cr-Commit-Position: refs/heads/master@{#14055} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1afdf99f9c00155b0c250e9a358de0184933b27c Cr-Commit-Position: refs/heads/master@{#14055} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
