Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2296693002: Fixed the clang warning for ApmDataDumper (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed the clang warning for ApmDataDumper BUG= Committed: https://crrev.com/f8f754a1a6d2aa437856edc7ae90d47c9b2b0ccd Cr-Commit-Position: refs/heads/master@{#13975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M webrtc/modules/audio_processing/logging/apm_data_dumper.h View 1 chunk +6 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/logging/apm_data_dumper.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
peah-webrtc
4 years, 3 months ago (2016-08-30 10:08:33 UTC) #2
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-08-30 10:14:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296693002/1
4 years, 3 months ago (2016-08-30 10:27:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15979)
4 years, 3 months ago (2016-08-30 11:09:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296693002/1
4 years, 3 months ago (2016-08-30 12:23:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-08-30 12:28:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296693002/1
4 years, 3 months ago (2016-08-30 14:06:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-30 16:07:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296693002/1
4 years, 3 months ago (2016-08-30 16:35:19 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:31:50 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:32:01 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f8f754a1a6d2aa437856edc7ae90d47c9b2b0ccd
Cr-Commit-Position: refs/heads/master@{#13975}

Powered by Google App Engine
This is Rietveld 408576698