Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2295923005: Add linux_use_bundled_binutils_override = true to build_overrides. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add linux_use_bundled_binutils_override = true to build_overrides. This variable was introduced in https://codereview.chromium.org/2293853002 and causes builds to fail, since is not defined in WebRTC. NOTRY=True BUG=webrtc:6281 Committed: https://crrev.com/70279215a609e6daa3b451b75074155e17cae111 Cr-Commit-Position: refs/heads/master@{#13987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-08-31 08:08:32 UTC) #3
kjellander_webrtc
Bake this into the roll CL instead.
4 years, 3 months ago (2016-08-31 08:33:54 UTC) #5
kjellander_webrtc
lgtm or, do whatever is easiest for you, since this passes.
4 years, 3 months ago (2016-08-31 08:34:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2295923005/1
4 years, 3 months ago (2016-08-31 08:37:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 08:59:56 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 09:00:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70279215a609e6daa3b451b75074155e17cae111
Cr-Commit-Position: refs/heads/master@{#13987}

Powered by Google App Engine
This is Rietveld 408576698