Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: webrtc/api/android/jni/peerconnection_jni.cc

Issue 2295493002: Add a switch to redetermine role when ICE restarts. (Closed)
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/android/jni/peerconnection_jni.cc
diff --git a/webrtc/api/android/jni/peerconnection_jni.cc b/webrtc/api/android/jni/peerconnection_jni.cc
index 5095b152ba0947af8eb45e1b5e36248299f20fff..2463c5cfae1507701c743647ca0c03b2f9821b1e 100644
--- a/webrtc/api/android/jni/peerconnection_jni.cc
+++ b/webrtc/api/android/jni/peerconnection_jni.cc
@@ -1631,6 +1631,9 @@ static void JavaRTCConfigurationToJsepRTCConfiguration(
jfieldID j_prune_turn_ports_id =
GetFieldID(jni, j_rtc_config_class, "pruneTurnPorts", "Z");
+ jfieldID j_redetermine_role_on_ice_restart_id =
pthatcher1 2016/08/29 23:27:42 If we're only going to use the switch in Chromium,
honghaiz3 2016/08/29 23:32:27 Done. Removed.
+ GetFieldID(jni, j_rtc_config_class, "redetermineRoleOnIceRestart", "Z");
+
rtc_config->type =
JavaIceTransportsTypeToNativeType(jni, j_ice_transports_type);
rtc_config->bundle_policy =
@@ -1655,10 +1658,12 @@ static void JavaRTCConfigurationToJsepRTCConfiguration(
jni, j_continual_gathering_policy);
rtc_config->ice_candidate_pool_size =
GetIntField(jni, j_rtc_config, j_ice_candidate_pool_size_id);
- rtc_config->prune_turn_ports =
- GetBooleanField(jni, j_rtc_config, j_prune_turn_ports_id);
rtc_config->presume_writable_when_fully_relayed = GetBooleanField(
jni, j_rtc_config, j_presume_writable_when_fully_relayed_id);
+ rtc_config->prune_turn_ports =
+ GetBooleanField(jni, j_rtc_config, j_prune_turn_ports_id);
+ rtc_config->redetermine_role_on_ice_restart =
+ GetBooleanField(jni, j_rtc_config, j_redetermine_role_on_ice_restart_id);
}
JOW(jlong, PeerConnectionFactory_nativeCreatePeerConnection)(

Powered by Google App Engine
This is Rietveld 408576698