Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2295493002: Add a switch to redetermine role when ICE restarts. (Closed)
Patch Set: Remove the objective-c change to submit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnectionfactory.cc ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index fdf9cef51ec2a2a8b419227522d085a36b2c4ad2..1dba14c41ab36183058e93efc0a312390818f8e3 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -240,6 +240,18 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// methods for all settings which are of interest to applications,
// Chrome in particular.
+ // A configuration that is safer to use, despite it may not have the best
+ // performance.
+ static RTCConfiguration SafeConfiguration() { return RTCConfiguration(); }
+
+ // An aggressive configuration that has better performance, although it
+ // may be riskier and may need extra support in the application.
+ static RTCConfiguration AggressiveConfiguration() {
+ RTCConfiguration config;
+ config.redetermine_role_on_ice_restart = false;
+ return config;
+ }
+
bool dscp() { return media_config.enable_dscp; }
void set_dscp(bool enable) { media_config.enable_dscp = enable; }
@@ -305,6 +317,9 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// If set to true, this means the ICE transport should presume TURN-to-TURN
// candidate pairs will succeed, even before a binding response is received.
bool presume_writable_when_fully_relayed = false;
+ // If true, ICE role is redetermined when peerconnection sets a local
+ // transport description that indicates an ICE restart.
+ bool redetermine_role_on_ice_restart = true;
};
struct RTCOfferAnswerOptions {
« no previous file with comments | « webrtc/api/peerconnectionfactory.cc ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698