Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2294883008: Add kjellander@webrtc.org to more OWNERS for BUILD.gn files. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, ehmaldonado_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add kjellander@webrtc.org to more OWNERS for BUILD.gn files. TBR=henrika@webrtc.org NOTRY=True Committed: https://crrev.com/c0f28be1ca5d5423d69d5019ce4d1717e75d15a9 Cr-Commit-Position: refs/heads/master@{#14045}

Patch Set 1 #

Patch Set 2 : Add kjellander@webrtc.org to more OWNERS for BUILD.gn files. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M webrtc/libjingle/OWNERS View 1 1 chunk +0 lines, -2 lines 1 comment Download
A webrtc/libjingle/xmllite/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
Should be the last missing ones.
4 years, 3 months ago (2016-09-02 11:57:45 UTC) #4
kjellander_webrtc
Should be the last ones https://codereview.webrtc.org/2294883008/diff/20001/webrtc/libjingle/OWNERS File webrtc/libjingle/OWNERS (left): https://codereview.webrtc.org/2294883008/diff/20001/webrtc/libjingle/OWNERS#oldcode12 webrtc/libjingle/OWNERS:12: per-file BUILD.gn=kjellander@webrtc.org I tried ...
4 years, 3 months ago (2016-09-02 11:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2294883008/20001
4 years, 3 months ago (2016-09-02 11:58:51 UTC) #7
henrika_webrtc
LGTM
4 years, 3 months ago (2016-09-02 11:59:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 12:04:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:04:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0f28be1ca5d5423d69d5019ce4d1717e75d15a9
Cr-Commit-Position: refs/heads/master@{#14045}

Powered by Google App Engine
This is Rietveld 408576698