Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2294693002: Making hbos and hta OWNERS of webrtc/api/rtcstats*. (Closed)

Created:
4 years, 3 months ago by hbos
Modified:
4 years, 3 months ago
Reviewers:
AlexG, hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making hbos and hta OWNERS of webrtc/api/rtcstats*. hbos and hta are webrtc/stats/ OWNERS. Public api headers relating to rtcstats are placed in webrtc/api/ and implementations are placed in webrtc/stats/. This ownership allows the rtcstats owners to own both .cc and .h files. For example, rtcstats.[h/cc] and rtcstatsreport.[h/cc]. (Soon there will also be rtcstats_objects.[h/cc] and more.) BUG=chromium:627816 Committed: https://crrev.com/6a60e70266ddb5ed203436be30f5b6ee641af05b Cr-Commit-Position: refs/heads/master@{#13981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/api/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hbos
Please take a look, glaznev and hta.
4 years, 3 months ago (2016-08-30 09:58:03 UTC) #4
hta-webrtc
lgtm
4 years, 3 months ago (2016-08-30 10:12:44 UTC) #5
AlexG
lgtm
4 years, 3 months ago (2016-08-30 17:06:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2294693002/20001
4 years, 3 months ago (2016-08-30 20:49:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-30 21:51:17 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:51:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a60e70266ddb5ed203436be30f5b6ee641af05b
Cr-Commit-Position: refs/heads/master@{#13981}

Powered by Google App Engine
This is Rietveld 408576698