rtc::Buffer: Let SetData and AppendData accept anything with .data() and .size()

webrtc/base/buffer_unittest.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/buffer.h"
+
+#include "webrtc/base/array_view.h"
 #include "webrtc/base/gunit.h"
 
 #include <type_traits>
 #include <utility>
 
 namespace rtc {
 
 namespace {
 
 // clang-format off
@@ skipping 41 matching lines @@
   EXPECT_EQ(buf.capacity(), 16u);
   EXPECT_EQ(0, memcmp(buf.data(), kTestData, 16));
 }
 
 TEST(BufferTest, TestSetData) {
   Buffer buf(kTestData + 4, 7);
   buf.SetData(kTestData, 9);
   EXPECT_EQ(buf.size(), 9u);
   EXPECT_EQ(buf.capacity(), 7u * 3 / 2);
   EXPECT_EQ(0, memcmp(buf.data(), kTestData, 9));
+  Buffer buf2;

[ossu, 2016/08/31 09:31:03]

Do you want to test this with an unrelated class as well? Just a test-local one
with data() and size() and basically nothing else? (well, except for some data,
I guess).

[kwiberg-webrtc, 2016/09/01 09:23:53]

Done.

+  buf2.SetData(buf);
+  EXPECT_EQ(buf.size(), 9u);
+  EXPECT_EQ(buf.capacity(), 7u * 3 / 2);
+  EXPECT_EQ(0, memcmp(buf.data(), kTestData, 9));
 }
 
 TEST(BufferTest, TestAppendData) {
   Buffer buf(kTestData + 4, 3);
   buf.AppendData(kTestData + 10, 2);
   const int8_t exp[] = {0x4, 0x5, 0x6, 0xa, 0xb};
   EXPECT_EQ(buf, Buffer(exp));
+  Buffer buf2;
+  buf2.AppendData(buf);
+  buf2.AppendData(rtc::ArrayView<uint8_t>(buf));
+  const int8_t exp2[] = {0x4, 0x5, 0x6, 0xa, 0xb, 0x4, 0x5, 0x6, 0xa, 0xb};
+  EXPECT_EQ(buf2, Buffer(exp2));
 }
 
 TEST(BufferTest, TestSetSizeSmaller) {
   Buffer buf;
   buf.SetData(kTestData, 15);
   buf.SetSize(10);
   EXPECT_EQ(buf.size(), 10u);
   EXPECT_EQ(buf.capacity(), 15u);  // Hasn't shrunk.
   EXPECT_EQ(buf, Buffer(kTestData, 10));
 }
@@ skipping 261 matching lines @@
   BufferT<BloodStone*> buf2(4);
   for (size_t i = 0; i < buf2.size(); ++i) {
     buf2[i] = &buf[i];
   }
   static const char kObsidian[] = "obsidian";
   buf2[2]->stone = kObsidian;
   EXPECT_EQ(kObsidian, buf[2].stone);
 }
 
 }  // namespace rtc