Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Issue 2293383002: GN: Use custom suppressions for lint in android. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Use custom suppressions for lint in android. Also, suppress lint warnings that were causing compiling errors. BUG=webrtc:6281 NOTRY=True Committed: https://crrev.com/08c047ee37ab8ea46e244c18bb06251d0316838e Cr-Commit-Position: refs/heads/master@{#13985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/build/android/suppressions.xml View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-08-31 08:21:54 UTC) #2
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-08-31 08:32:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2293383002/1
4 years, 3 months ago (2016-08-31 08:33:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 08:55:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 08:55:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08c047ee37ab8ea46e244c18bb06251d0316838e
Cr-Commit-Position: refs/heads/master@{#13985}

Powered by Google App Engine
This is Rietveld 408576698