Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2292863002: Introduced new scheme for controlling the functionality inside the audio processing module (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index d0ca9aea617322719caf5cf0184c92128e25cb07..c89e76f0898b6f314f34f3683d831db4efea2c44 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -873,7 +873,9 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
LOG(LS_INFO) << "Level control: "
<< (!!level_control_ ? *level_control_ : -1);
if (level_control_) {
- config.Set<webrtc::LevelControl>(new webrtc::LevelControl(*level_control_));
the sun 2016/08/30 10:32:38 oh, yeah! :)
peah-webrtc 2016/08/30 17:05:57 :-)
+ webrtc::ApmSettings apm_settings;
+ apm_settings.level_controller.enabled = *level_control_;
+ voe_wrapper_->base()->audio_processing()->ApplySettings(apm_settings);
the sun 2016/08/30 10:32:38 Move line 883 up before this block instead.
hlundin-webrtc 2016/08/30 11:26:26 Verify the settings before applying.
peah-webrtc 2016/08/30 17:05:57 Makes sense. What I did now is that I split out ap
peah-webrtc 2016/08/30 17:05:57 Done.
}
// We check audioproc for the benefit of tests, since FakeWebRtcVoiceEngine

Powered by Google App Engine
This is Rietveld 408576698